Files: 
CommentFileSizeAuthor
#19 views-core-rename-sort-options-2003246-19.patch1.05 KBnathangervais
PASSED: [[SimpleTest]]: [MySQL] 57,148 pass(es).
[ View ]
#19 interdiff.txt717 bytesnathangervais
#16 interdiff.txt717 bytesnathangervais
#16 views-core-rename-sort-options-2003246-13.patch1.04 KBnathangervais
PASSED: [[SimpleTest]]: [MySQL] 57,226 pass(es).
[ View ]
#14 views-core-rename-sort-options-2003246-13.patch1.04 KBDan Reinders
PASSED: [[SimpleTest]]: [MySQL] 57,164 pass(es).
[ View ]
#12 views-core-sortOptions-2003246-12.patch1.03 KBDan Reinders
FAILED: [[SimpleTest]]: [MySQL] 55,622 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#7 2003246-7449576-2.patch1.03 KBendorn
PASSED: [[SimpleTest]]: [MySQL] 55,755 pass(es).
[ View ]
#5 2003246-7449576.patch1.02 KBendorn
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

Assigned:Unassigned» farfanfelipe

Assigned:farfanfelipe» endorn

Assigned:endorn» Unassigned

Assigned:Unassigned» endorn

StatusFileSize
new1.02 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

renamed function names.

Status:Active» Needs review

StatusFileSize
new1.03 KB
PASSED: [[SimpleTest]]: [MySQL] 55,755 pass(es).
[ View ]

forgot to add public.

Status:Needs review» Reviewed & tested by the community

Looks good.

Status:Reviewed & tested by the community» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, 2003246-7449576-2.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

#7: 2003246-7449576-2.patch queued for re-testing.

Status:Needs review» Needs work

Unfortunately we need a reroll, the patch doesn't apply anymore.

Status:Needs work» Needs review
StatusFileSize
new1.03 KB
FAILED: [[SimpleTest]]: [MySQL] 55,622 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

re-rolled

Status:Needs review» Needs work

The last submitted patch, views-core-sortOptions-2003246-12.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new1.04 KB
PASSED: [[SimpleTest]]: [MySQL] 57,164 pass(es).
[ View ]

patch 12 no longer applies.

re-rolled

Status:Needs review» Needs work

Should be protected

=> protected function sortOptions() {

Assigned:endorn» nathangervais
Status:Needs work» Needs review
StatusFileSize
new1.04 KB
PASSED: [[SimpleTest]]: [MySQL] 57,226 pass(es).
[ View ]
new717 bytes

Here's the old patch with an interdiff to add the protected access modifier.

Status:Needs review» Needs work

Patch odesn't contain the access modifier

It looks like the same patch from #13 was mistakenly re-uploaded.

Status:Needs work» Needs review
StatusFileSize
new717 bytes
new1.05 KB
PASSED: [[SimpleTest]]: [MySQL] 57,148 pass(es).
[ View ]

Apologies I had thought i was supposed to supply the original patch with the interdiff. Here's the new patch with the interdiff.

It's no problem. The interdiff just shows the change you made between the old patch and the new one so that it's easy for reviewers to see the changes that you've made.

Status:Needs review» Reviewed & tested by the community

Perfect!

Status:Reviewed & tested by the community» Fixed

Committed eb60f6f and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.