Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#26 | 2003252-26.patch | 1.22 KB | jibran |
#26 | interdiff.txt | 841 bytes | jibran |
#24 | 2003252-24.patch | 1.21 KB | jibran |
#21 | core-rename_show_value_form_TO_showValueForm-2003252-21.patch | 1.22 KB | ThomasVI |
#18 | core-rename_show_value_form_TO_showValueForm-2003252-18.patch | 60.48 KB | ThomasVI |
Comments
Comment #1
ThomasVI CreditAttribution: ThomasVI commentedComment #2
ThomasVI CreditAttribution: ThomasVI commentedComment #3
ThomasVI CreditAttribution: ThomasVI commentedadded a more descriptive patch name
Comment #4
ThomasVI CreditAttribution: ThomasVI commentedComment #6
ThomasVI CreditAttribution: ThomasVI commented#3: core-rename_show_value_form_TO_showValueForm-2003252-2.patch queued for re-testing.
Comment #8
ThomasVI CreditAttribution: ThomasVI commentedComment #10
ThomasVI CreditAttribution: ThomasVI commented#8: core-rename_show_value_form_TO_showValueForm-2003252-8.patch queued for re-testing.
Comment #12
ThomasVI CreditAttribution: ThomasVI commentedI have read through the error, and I can not see why this change camelCase change would have any impact on the BlockRenderOrderTest.php test. Could anyone advise?
Comment #13
SpartyDan CreditAttribution: SpartyDan commentedI couldn't find the issue but this is a known problem that was fixed. I am re-queuing your patch for testing.
Comment #14
SpartyDan CreditAttribution: SpartyDan commented#8: core-rename_show_value_form_TO_showValueForm-2003252-8.patch queued for re-testing.
Comment #15
ThomasVI CreditAttribution: ThomasVI commentedThank you Dan.
Comment #16
aspilicious CreditAttribution: aspilicious commentedShould be "protected function showValueForm"
Comment #17
ThomasVI CreditAttribution: ThomasVI commentedComment #18
ThomasVI CreditAttribution: ThomasVI commentedRecreated patch to add the protected function showValueForm as per aspilicious in comment #16. ty
Comment #19
ThomasVI CreditAttribution: ThomasVI commentedComment #20
ThomasVI CreditAttribution: ThomasVI commentedComment #21
ThomasVI CreditAttribution: ThomasVI commentedLast patch was bad, re-rolled
Comment #22
dawehnerLooks great.
Comment #23
alexpottNeeds a re-roll
Comment #24
jibranRe-roll
Conflicts
Resolved
Comment #25
aspilicious CreditAttribution: aspilicious commentedShould be "protected function ... "
Comment #26
jibranupdated the function to protected.
Comment #27
dawehnerCool.
Comment #28
alexpottCommitted b1fcd53 and pushed to 8.x. Thanks!