Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#4 views-2003264-3-showBuildGroupForm.patch1.05 KBshoptalk
#2 views-2003264-showBuildGroupForm.patch1.04 KBphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima commented
Assigned: Unassigned » phenaproxima
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima commented
Assigned: phenaproxima » Unassigned
Status: Active » Needs review
FileSize
views-2003264-showBuildGroupForm.patch1.04 KB

Status: Needs review » Needs work

The last submitted patch, views-2003264-showBuildGroupForm.patch, failed testing.

shoptalk’s picture

shoptalk CreditAttribution: shoptalk commented
Status: Needs work » Needs review
FileSize
views-2003264-3-showBuildGroupForm.patch1.05 KB

Added public to method declaration

kevin.reiss’s picture

kevin.reiss CreditAttribution: kevin.reiss commented
Status: Needs review » Reviewed & tested by the community

Looks good.

Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, views-2003264-3-showBuildGroupForm.patch, failed testing.

shoptalk’s picture

shoptalk CreditAttribution: shoptalk commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#4: views-2003264-3-showBuildGroupForm.patch queued for re-testing.

gdf’s picture

gdf CreditAttribution: gdf commented
Status: Needs review » Reviewed & tested by the community

retest was successful; code looks good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed dc44c60 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.