Files: 
CommentFileSizeAuthor
#15 views-core-rename-show-build-group-button-2003266-15.patch1.09 KBDan Reinders
PASSED: [[SimpleTest]]: [MySQL] 57,516 pass(es).
[ View ]
#13 drupal-rename_show_build_group_button-2003266-13.patch1.09 KBiStryker
PASSED: [[SimpleTest]]: [MySQL] 57,242 pass(es).
[ View ]
#13 interdiff.txt640 bytesiStryker
#4 2003266_changetoCamelCase.patch1.15 KBmisselbeck
PASSED: [[SimpleTest]]: [MySQL] 56,658 pass(es).
[ View ]
#3 drupal-rename-show-build-group-button-2003266-2.patch1.08 KBkenianbei
PASSED: [[SimpleTest]]: [MySQL] 55,836 pass(es).
[ View ]

Comments

Assigned:Unassigned» kenianbei

Assigned:kenianbei» misselbeck

Working on DrupalCon 2013 Sprint

Assigned:misselbeck» kenianbei
Status:Active» Needs review
StatusFileSize
new1.08 KB
PASSED: [[SimpleTest]]: [MySQL] 55,836 pass(es).
[ View ]

Assigned:kenianbei» Unassigned
StatusFileSize
new1.15 KB
PASSED: [[SimpleTest]]: [MySQL] 56,658 pass(es).
[ View ]

Ooops...double patch.

Assigned:Unassigned» kenianbei

No problem, just make sure that the issue hasn't been taken by someone before you take it on. You also should check out this page on patch naming conventions: http://drupal.org/node/707484

git diff 7.x-1.x > [project_name]-[short-description]-[issue-number]-[comment-number].patch

Status:Needs review» Needs work

The last submitted patch, 2003266_changetoCamelCase.patch, failed testing.

Failing tests. Please test and re-roll.

Status:Needs work» Needs review

Shouldn't the function be rename as either a public or a protected function?

If it is only used internally i.e. $this->{foo} then protected seems appropriate. Otherwise use public.

#4: 2003266_changetoCamelCase.patch queued for re-testing.

Assigned:kenianbei» Unassigned
StatusFileSize
new640 bytes
new1.09 KB
PASSED: [[SimpleTest]]: [MySQL] 57,242 pass(es).
[ View ]

Following @heddn advice, making the function public.

Status:Needs review» Needs work

Following the advice of heddn I would argue to make it protected.

I also can't see a reason why this method would be called outside of filters.

Status:Needs work» Needs review
StatusFileSize
new1.09 KB
PASSED: [[SimpleTest]]: [MySQL] 57,516 pass(es).
[ View ]

function changed to protected

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Fixed

Committed 51777f2 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.