Files: 
CommentFileSizeAuthor
#20 drupal_core-views-rename_setWhereGroup-2003270-20.patch2.52 KBmarkie
PASSED: [[SimpleTest]]: [MySQL] 55,471 pass(es).
[ View ]
#18 2003270-18.patch2.52 KBjibran
FAILED: [[SimpleTest]]: [MySQL] 56,301 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#13 views_rename_setWhereGroup-2003270-12.patch2.83 KBmarkie
PASSED: [[SimpleTest]]: [MySQL] 55,908 pass(es).
[ View ]
#11 views_rename_setWhereGroup-2003270-11.patch2.83 KBmarkie
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views_rename_setWhereGroup-2003270-11.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#7 views-core-set_where_group-2003270-7.patch2.82 KBDan Reinders
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]
#1 rename_setWhereGroup-2003270-1.patch2.82 KBmarkie
FAILED: [[SimpleTest]]: [MySQL] 55,901 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Comments

Assigned:Unassigned» markie
Status:Active» Needs review
StatusFileSize
new2.82 KB
FAILED: [[SimpleTest]]: [MySQL] 55,901 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

three files patched

Status:Needs review» Reviewed & tested by the community

Applied the patch, tested out views, and nothing broke. I wasn't able to find the exact trigger for this function, but it looked fairly well!

Status:Reviewed & tested by the community» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, rename_setWhereGroup-2003270-1.patch, failed testing.

Status:Needs work» Needs review

#1: rename_setWhereGroup-2003270-1.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+Novice, +VDC

The last submitted patch, rename_setWhereGroup-2003270-1.patch, failed testing.

Failing tests. Please test and re-roll.

Status:Needs work» Needs review
StatusFileSize
new2.82 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Re-rolled

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, views-core-set_where_group-2003270-7.patch, failed testing.

Status:Needs work» Needs review

Status:Needs review» Needs work
Issue tags:+Novice, +VDC

The last submitted patch, views-core-set_where_group-2003270-7.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new2.83 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views_rename_setWhereGroup-2003270-11.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

rerolled against fresh pull.

Status:Needs review» Needs work

The last submitted patch, views_rename_setWhereGroup-2003270-11.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new2.83 KB
PASSED: [[SimpleTest]]: [MySQL] 55,908 pass(es).
[ View ]

rerolled

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, views_rename_setWhereGroup-2003270-12.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

Status:Reviewed & tested by the community» Needs work

needs reroll

curl https://drupal.org/files/views_rename_setWhereGroup-2003270-12.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2894  100  2894    0     0   3897      0 --:--:-- --:--:-- --:--:--  5077
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php:962
error: core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php: patch does not apply

Status:Needs work» Needs review
StatusFileSize
new2.52 KB
FAILED: [[SimpleTest]]: [MySQL] 56,301 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

reroll

Status:Needs review» Needs work

The last submitted patch, 2003270-18.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new2.52 KB
PASSED: [[SimpleTest]]: [MySQL] 55,471 pass(es).
[ View ]

re-re-roll

Status:Needs review» Reviewed & tested by the community

#20 looks good to me. All instances of the method name have been rewritten. The method visibility is set to public.

Status:Reviewed & tested by the community» Fixed

Committed 9048d3b and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.