Files: 
CommentFileSizeAuthor
#15 drupal-viewsRename-set_items_per_page-2003282-15.patch4.45 KBheddn
PASSED: [[SimpleTest]]: [MySQL] 58,022 pass(es).
[ View ]
#15 interdiff.txt570 bytesheddn
#10 2003282-rename-set_items_per_page.patch3.77 KBsillygwailo
FAILED: [[SimpleTest]]: [MySQL] 57,146 pass(es), 2 fail(s), and 0 exception(s).
[ View ]
#7 rename-set-items-per-page-2003282-7.patch3.81 KBtheladebug
FAILED: [[SimpleTest]]: [MySQL] 57,435 pass(es), 2 fail(s), and 0 exception(s).
[ View ]
#5 rename-set-items-per-page-2003282.patch3.81 KBtheladebug
FAILED: [[SimpleTest]]: [MySQL] 57,077 pass(es), 2 fail(s), and 0 exception(s).
[ View ]
#2 updated-function-name-2003282.patch3.15 KBtheladebug
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

Assigned:Unassigned» theladebug

Status:Active» Needs review
StatusFileSize
new3.15 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Status:Needs review» Needs work

The last submitted patch, updated-function-name-2003282.patch, failed testing.

Status:Needs work» Needs review

StatusFileSize
new3.81 KB
FAILED: [[SimpleTest]]: [MySQL] 57,077 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Status:Needs review» Needs work

The last submitted patch, rename-set-items-per-page-2003282.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new3.81 KB
FAILED: [[SimpleTest]]: [MySQL] 57,435 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

changed function visibility to public

Status:Needs review» Needs work

The last submitted patch, rename-set-items-per-page-2003282-7.patch, failed testing.

This issue is related to #2002920: Rename Views method get_items_per_page() to getItemsPerPage() and that issue should maybe get resolved before this one, where references to get_items_per_page() for this patch are changed to getItemsPerPage() (i.e. a manual merge conflict resolution might be necessary).

Status:Needs work» Needs review
StatusFileSize
new3.77 KB
FAILED: [[SimpleTest]]: [MySQL] 57,146 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, 2003282-rename-set_items_per_page.patch, failed testing.

Status:Needs work» Needs review

Status:Needs review» Needs work
Issue tags:+Novice, +VDC

The last submitted patch, 2003282-rename-set_items_per_page.patch, failed testing.

Assigned:theladebug» drupee
Status:Needs work» Active

Status:Active» Needs review
StatusFileSize
new570 bytes
new4.45 KB
PASSED: [[SimpleTest]]: [MySQL] 58,022 pass(es).
[ View ]

Switched to public. Let's see if that makes the testbot happy.

Status:Needs review» Reviewed & tested by the community

There we go! No other instances left.

Status:Reviewed & tested by the community» Fixed

Committed b69a5af and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.