Files: 
CommentFileSizeAuthor
#11 views-core-rename-set_distinct-2003288-11.patch1011 bytesDan Reinders
PASSED: [[SimpleTest]]: [MySQL] 56,109 pass(es).
[ View ]
#5 Rename_Views_method-2003288-5.patch1001 bytesNonProfit
PASSED: [[SimpleTest]]: [MySQL] 55,723 pass(es).
[ View ]

Comments

Assigned:Unassigned» NonProfit

Assigned:NonProfit» phenaproxima

Oops - sorry, NonProfit! I think we both took this on at the same moment. I'll take another issue; didn't mean to step on your toes.

Assigned:phenaproxima» Unassigned

Durr, forgot to unassign from myself.

Status:Active» Needs review
StatusFileSize
new1001 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,723 pass(es).
[ View ]

Thanks phenaproxima; no worries.

Status:Needs review» Needs work

The last submitted patch, Rename_Views_method-2003288-5.patch, failed testing.

Assigned:Unassigned» NonProfit

Status:Needs work» Needs review

#5: Rename_Views_method-2003288-5.patch queued for re-testing.

Assigned:NonProfit» Unassigned

Status:Needs review» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -158,7 +158,7 @@ public function init(ViewExecutable $view, DisplayPluginBase $display, array &$o
+  function setDistinct($value = TRUE) {

Add protected access modifier in front of the function to adhere to the new OOP standards.

All occurences have been replaced, so after the correction, the patch should be RTBC...

Status:Needs work» Needs review
StatusFileSize
new1011 bytes
PASSED: [[SimpleTest]]: [MySQL] 56,109 pass(es).
[ View ]

Added protected access modifier in front of the function to adhere to the new OOP standards.

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, views-core-rename-set_distinct-2003288-11.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

Status:Reviewed & tested by the community» Fixed

Committed 42af4a5 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.