Files: 
CommentFileSizeAuthor
#6 views-core-rename-sanitize_columns-2003310-06.patch1.79 KBDan Reinders
PASSED: [[SimpleTest]]: [MySQL] 56,029 pass(es).
[ View ]
#4 views-core-rename-sanitize_columns-2003310-04.patch1.78 KBDan Reinders
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views-core-rename-sanitize_columns-2003310-04.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#2 views-2003310-sanitizeColumns.patch1.78 KBphenaproxima
Test request sent.
[ View ]

Comments

Assigned:Unassigned» phenaproxima

Assigned:phenaproxima» Unassigned
Status:Active» Needs review
StatusFileSize
new1.78 KB
Test request sent.
[ View ]

Status:Needs review» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/style/Table.phpundefined
@@ -185,7 +185,7 @@ function build_sort_post() {
+  function sanitizeColumns($columns, $fields = NULL) {

Add public access modifier in front of the function to adhere to the new OOP standards.

All occurrences are replaced, so the corrected patch should be RTBC.

Status:Needs work» Needs review
StatusFileSize
new1.78 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views-core-rename-sanitize_columns-2003310-04.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Added public access modifier in front of the function to adhere to the new OOP standards.

Status:Needs review» Needs work

The last submitted patch, views-core-rename-sanitize_columns-2003310-04.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new1.79 KB
PASSED: [[SimpleTest]]: [MySQL] 56,029 pass(es).
[ View ]

re-rolled

Status:Needs review» Reviewed & tested by the community

Cool

Status:Reviewed & tested by the community» Fixed

Committed 9ae13bc and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.