Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#5 | rename_views_method-2003334-5.patch | 3.14 KB | marlatt |
#5 | interdiff.txt | 950 bytes | marlatt |
#2 | views-2003334-renderGrouping.patch | 3.13 KB | phenaproxima |
Comments
Comment #1
phenaproximaComment #2
phenaproximaPatch attached; for whatever it's worth, it passed all the tests for Views style plugins on my localhost.
Comment #3
oenie CreditAttribution: oenie commentedAdd the access modifier public in front of the function declaration. To adher to the new OOP standards and since it's being called directly on an object from the outside (in core/modules/views/lib/Drupal/views/Tests/Plugin/StyleTest.php)
Comment #5
marlatt CreditAttribution: marlatt commentedAdded access modifier.
Comment #6
oenie CreditAttribution: oenie commentedLooks good to me now !
Comment #7
alexpottCommitted cdb78e0 and pushed to 8.x. Thanks!