Problem/Motivation

Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

Proposed resolution

Use grep -r "render_exposed_form(" . to find all instances of render_exposed_form(
Replace render_exposed_form( with renderExposedForm(

Remaining tasks

reviews needed

[META] Rename Views methods to core standards

CommentFileSizeAuthor
#7 2003346-render_exposed_form-7.patch3.13 KBJimSmith
#2 2003346-render_exposed_form.patch3.12 KBJimSmith
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JimSmith’s picture

JimSmith CreditAttribution: JimSmith commented
Assigned: Unassigned » JimSmith
JimSmith’s picture

JimSmith CreditAttribution: JimSmith commented
Status: Active » Needs review
FileSize
2003346-render_exposed_form.patch3.12 KB

Patch for review.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2003346-render_exposed_form.patch, failed testing.

JimSmith’s picture

JimSmith CreditAttribution: JimSmith commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#2: 2003346-render_exposed_form.patch queued for re-testing.

Previous test failed because it failed to checkout from git. I'm hoping that was just a result of so many patches being submitted at the same time during the Drupalcon Portland code sprint.

JimSmith’s picture

JimSmith CreditAttribution: JimSmith commented

Okay. Passed this time. Ready for review.

oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/exposed_form/ExposedFormPluginBase.phpundefined
@@ -115,7 +115,7 @@ public function buildOptionsForm(&$form, &$form_state) {
+  function renderExposedForm($block = FALSE) {

Add public access modifier in front of the function to adhere to the new OOP standards.

JimSmith’s picture

JimSmith CreditAttribution: JimSmith commented
Status: Needs work » Needs review
FileSize
2003346-render_exposed_form-7.patch3.13 KB

Alrighty then. Public access modifier added to front of the function to adhere to the new OOP standards and re-rolled.

oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 15d26ab and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

updated summary of issue