Files: 
CommentFileSizeAuthor
#15 2003350-15-rename-render_altered.patch1.44 KBelvis2
PASSED: [[SimpleTest]]: [MySQL] 56,037 pass(es).
[ View ]
#13 2003350-13-rename-render_altered.patch1.44 KBelvis2
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]
#9 2003350-9.patch1.42 KBjibran
PASSED: [[SimpleTest]]: [MySQL] 56,178 pass(es).
[ View ]
#4 views-rename_function-2003350-4.patch1.42 KBtvlooy
PASSED: [[SimpleTest]]: [MySQL] 57,852 pass(es).
[ View ]
#2 views-rename_function-2003350-2.patch1.42 KBdruderman
PASSED: [[SimpleTest]]: [MySQL] 55,729 pass(es).
[ View ]

Comments

Assigned:Unassigned» druderman

At drupalcon sprint

Status:Active» Needs review
StatusFileSize
new1.42 KB
PASSED: [[SimpleTest]]: [MySQL] 55,729 pass(es).
[ View ]

Status:Needs review» Needs work

Thanks for working on this. You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.

You can see an example patch here: http://drupal.org/node/2001672

Status:Needs work» Needs review
StatusFileSize
new1.42 KB
PASSED: [[SimpleTest]]: [MySQL] 57,852 pass(es).
[ View ]

Added the access modifier.

Status:Needs review» Reviewed & tested by the community

Looks good.

Reviewed patch based on the following criteria: http://drupal.org/node/1856630#comment-7450696

Good catch. Thanks Tvlooy.

Assigned:druderman» Unassigned

Status:Reviewed & tested by the community» Needs work

Needs re-roll

curl http://drupal.org/files/views-rename_function-2003350-4.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1456  100  1456    0     0   4127      0 --:--:-- --:--:-- --:--:--  8416
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php:1208
error: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php: patch does not apply

Status:Needs work» Needs review
StatusFileSize
new1.42 KB
PASSED: [[SimpleTest]]: [MySQL] 56,178 pass(es).
[ View ]

Reroll

conflict

++<<<<<<< HEAD
+      $tokens = $this->getRenderTokens($alter);
+      $value = $this->render_altered($alter, $tokens);
++=======
+       $tokens = $this->get_render_tokens($alter);
+       $value = $this->renderAltered($alter, $tokens);
++>>>>>>> 2

resolved
-      $tokens = $this->get_render_tokens($alter);
+      $tokens = $this->getRenderTokens($alter);
-       $value = $this->render_altered($alter, $tokens);
+       $value = $this->renderAltered($alter, $tokens);

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, 2003350-9.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

#9: 2003350-9.patch queued for re-testing.

Status:Needs review» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -1279,7 +1279,7 @@ public function renderText($alter) {
+  function renderAltered($alter, $tokens) {

It's just used internally, so it should be marked as protected.

Status:Needs work» Needs review
StatusFileSize
new1.44 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]

Re-rolled based on most recent pull of 8.x branch.

Edit: please cancel this patch, if possible, since it has an error in the code.

Should be protected

StatusFileSize
new1.44 KB
PASSED: [[SimpleTest]]: [MySQL] 56,037 pass(es).
[ View ]

Thanks @dawehner. Re-rolled.

Status:Needs review» Reviewed & tested by the community

Thank you!

Status:Reviewed & tested by the community» Fixed

Committed 49fb3c5 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.