Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#8 | views_rename_prepare_filter_select-2003364-8.patch | 1.69 KB | Sam Moore |
#6 | renamefunction-2003364-6.patch | 1.68 KB | Sam Moore |
#2 | renamefunction-2003364-2.patch | 1.68 KB | Sam Moore |
Comments
Comment #1
Sam MooreI'll have a look.
Comment #2
Sam MooreSee patch attached. This has passed local testing on Views Plugins.
Please review.
Comment #4
Sam Moore#2: renamefunction-2003364-2.patch queued for re-testing.
Comment #6
Sam MooreSee re-uploaded patch attached. This has passed local testing on Views Plugins.
Please review.
Comment #7
oenie CreditAttribution: oenie commentedAdd protected access modifier in front of the function to adhere to the new OOP standards.
All occurences seem to be replaced. The corrected patch should then be RTBC...
Comment #8
Sam MooreAdded "protected" access modifier to method
Comment #9
oenie CreditAttribution: oenie commentedLooks fine to me now !
Comment #10
alexpottCommitted a2b14f1 and pushed to 8.x. Thanks!