Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#12 Drupal_core-Rename-Views-method-offset_expose-to-isOffsetExposed-2003412-12.patch1.75 KBptocheia
#9 Drupal_core-Rename-Views-method-offset_expose-to-isOffsetExposed-2003412-9.patch1.74 KBptocheia
#7 Drupal_core-Rename-Views-method-offset_expose-to-isOffsetExposed-2003412-7.patch1.88 KBptocheia
#2 Drupal_core-Rename-Views-method-offset_expose-to-isOffsetExposed-2003412-2.patch1.86 KBlouisjimenez
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

louisjimenez’s picture

louisjimenez CreditAttribution: louisjimenez commented
Issue tags: +Novice, +VDC

I'm working on this at the DrupalCon Portland sprint.

louisjimenez’s picture

louisjimenez CreditAttribution: louisjimenez commented
Status: Active » Needs review
FileSize
Drupal_core-Rename-Views-method-offset_expose-to-isOffsetExposed-2003412-2.patch1.86 KB

Patch attached

Status: Needs review » Needs work

The last submitted patch, Drupal_core-Rename-Views-method-offset_expose-to-isOffsetExposed-2003412-2.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented
Status: Needs work » Needs review
louisjimenez’s picture

louisjimenez CreditAttribution: louisjimenez commented

#2: Drupal_core-Rename-Views-method-offset_expose-to-isOffsetExposed-2003412-2.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.phpundefined
@@ -253,7 +253,7 @@ function items_per_page_exposed() {
+  function isOffsetExposed() {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/SqlBase.phpundefined
@@ -324,14 +324,14 @@ function update_page_info() {
+  function isOffsetExposed() {

Should be a public method.

ptocheia’s picture

ptocheia CreditAttribution: ptocheia commented
Status: Needs work » Needs review
FileSize
Drupal_core-Rename-Views-method-offset_expose-to-isOffsetExposed-2003412-7.patch1.88 KB

Public has been added, patch attached.

Status: Needs review » Needs work

The last submitted patch, Drupal_core-Rename-Views-method-offset_expose-to-isOffsetExposed-2003412-7.patch, failed testing.

ptocheia’s picture

ptocheia CreditAttribution: ptocheia commented
Status: Needs work » Needs review
FileSize
Drupal_core-Rename-Views-method-offset_expose-to-isOffsetExposed-2003412-9.patch1.74 KB

OK, trying this again. Sorry, it's my first time trying to patch!

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented
Status: Needs review » Reviewed & tested by the community

Looks good.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Reviewed & tested by the community » Needs work

Only used by pager plugins. SHould be protected in stead of public.

ptocheia’s picture

ptocheia CreditAttribution: ptocheia commented
Status: Needs work » Needs review
FileSize
Drupal_core-Rename-Views-method-offset_expose-to-isOffsetExposed-2003412-12.patch1.75 KB

Both instances of public changed to protected.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 949f67b and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.