Files: 
CommentFileSizeAuthor
#6 2003462-06-rename-operator_submit-to-operatorSubmit.patch1.18 KBtvlooy
PASSED: [[SimpleTest]]: [MySQL] 55,885 pass(es).
[ View ]
#2 2003462-02-rename-operator_submit-to-operatorSubmit.patch1.17 KBDan Reinders
Test request sent.
Previous result: FAILED: [[SimpleTest]]: [MySQL] 55,740 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#1 2003462-01-rename-operator_submit-to-operatorSubmit.patch1.17 KBDan Reinders
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new1.17 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

renamed operator_submit to operatorSubmit

StatusFileSize
new1.17 KB
Test request sent.
Previous result: FAILED: [[SimpleTest]]: [MySQL] 55,740 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

changed functions to public functions

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, 2003462-02-rename-operator_submit-to-operatorSubmit.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

Status:Needs review» Needs work

Thanks for working on this. You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.

You can see an example patch here: http://drupal.org/node/2001672

StatusFileSize
new1.18 KB
PASSED: [[SimpleTest]]: [MySQL] 55,885 pass(es).
[ View ]

Added access modifier.

Status:Needs work» Needs review

Status:Needs review» Reviewed & tested by the community

Looks good.

Reviewed patch based on the following criteria: http://drupal.org/node/1856630#comment-7450696

Status:Reviewed & tested by the community» Fixed

Committed a39c996 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.