Files: 
CommentFileSizeAuthor
#6 drupal.camelcase-replace.2003476.6.patch1.16 KBbaldwinlouie
PASSED: [[SimpleTest]]: [MySQL] 57,829 pass(es).
[ View ]
#3 drupal-camelcase-replace-2003476-7451294.patch1.15 KBbaldwinlouie
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

Assigned:Unassigned» baldwinlouie

taking it with sillygwailo

Status:Active» Needs review
StatusFileSize
new1.15 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

attaching patch

Status:Needs review» Needs work

The last submitted patch, drupal-camelcase-replace-2003476-7451294.patch, failed testing.

All occurrences replaced; fix the issue below and it can be marked RTBC !

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/relationship/GroupwiseMax.phpundefined
@@ -160,7 +160,7 @@ public function buildOptionsForm(&$form, &$form_state) {
+  function getTemporaryView() {

Add protected access modifier in front of the function to adhere to the new OOP standards.

Status:Needs work» Needs review
StatusFileSize
new1.16 KB
PASSED: [[SimpleTest]]: [MySQL] 57,829 pass(es).
[ View ]

changed access modifier to protected. Re-rolled patch

Looks fine to me now ! Once the patch passed testbot, it's RTBC for me.

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Fixed
Issue tags:-VDC

Committed 0a563e8 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.