Files: 
CommentFileSizeAuthor
#10 views-rename_op_stars-2003554-10.patch1.69 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 55,875 pass(es).
[ View ]
#7 drupal_rename_op_starts-2003510-7.patch1.68 KBnathangervais
FAILED: [[SimpleTest]]: [MySQL] 55,830 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#4 views-rename_op_starts_to_addStartsWith-2003510-5.patch1.69 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 57,883 pass(es).
[ View ]
#2 drupal-Views_method-opstarts-2003510-2.patch1.68 KBjoeystern
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

Assigned:Unassigned» joeystern

Assigned:joeystern» Unassigned
Status:Active» Needs review
StatusFileSize
new1.68 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Completed change listed here, now requires check

Status:Needs review» Needs work

The last submitted patch, drupal-Views_method-opstarts-2003510-2.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new1.69 KB
PASSED: [[SimpleTest]]: [MySQL] 57,883 pass(es).
[ View ]

rename views method op_starts() to addStartsWith().

Patch attached.

Status:Needs review» Reviewed & tested by the community

Done

Status:Reviewed & tested by the community» Needs work

In #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_whatever to addWhatever. So to be consistent this patch should just change the name to opStartsWith - I'm okay with adding the With as this makes sense.

Status:Needs work» Needs review
StatusFileSize
new1.68 KB
FAILED: [[SimpleTest]]: [MySQL] 55,830 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Rerolled patch to rename op_starts() to opStartsWith()

Title:Rename Views method op_starts() to addStartsWith()Rename Views method op_starts() to opStartsWith()

Fixing title.

Status:Needs review» Needs work

The last submitted patch, drupal_rename_op_starts-2003510-7.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new1.69 KB
PASSED: [[SimpleTest]]: [MySQL] 55,875 pass(es).
[ View ]

rename op_starts() to opStartsWith().

Status:Needs review» Reviewed & tested by the community

Seems fine.

Status:Reviewed & tested by the community» Fixed

Committed 995e449 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.