Files: 
CommentFileSizeAuthor
#15 rename_views_method-2003536-15.patch2.62 KBmarlatt
PASSED: [[SimpleTest]]: [MySQL] 56,228 pass(es).
[ View ]
#15 interdiff.txt2.09 KBmarlatt
#12 drupal_rename_op_regex-2003536-12.patch2.61 KBnathangervais
PASSED: [[SimpleTest]]: [MySQL] 55,611 pass(es).
[ View ]
#10 drupal_rename_op_regex-2003536-10.patch2.61 KBnathangervais
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]
#7 interdiff.txt2.24 KBmarlatt
#7 accessmodifier-2003536-7.patch2.62 KBmarlatt
PASSED: [[SimpleTest]]: [MySQL] 56,656 pass(es).
[ View ]
#5 Rename_Views_method-2003536-5.patch2.6 KBNonProfit
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

Assigned:Unassigned» toddtomlinson

Assigned:sassafrass» Unassigned

Assigned:Unassigned» NonProfit

Assigned:NonProfit» Unassigned
Status:Active» Needs review
StatusFileSize
new2.6 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Patch created.

Status:Needs review» Needs work

The last submitted patch, Rename_Views_method-2003536-5.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new2.62 KB
PASSED: [[SimpleTest]]: [MySQL] 56,656 pass(es).
[ View ]
new2.24 KB

Updated access modifiers, re-rolled patch.

Status:Needs review» Reviewed & tested by the community

Done

Status:Reviewed & tested by the community» Needs work

In #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_whatever to addWhatever. So to be consistent this patch should just change the name to opRegex()

Status:Needs work» Needs review
StatusFileSize
new2.61 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]

Rerolled patch to rename op_regex to opRegex

Status:Needs review» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/Numeric.phpundefined
@@ -275,7 +275,7 @@ function op_empty($field) {
+  function opRegex($field) {

public?

Status:Needs work» Needs review
StatusFileSize
new2.61 KB
PASSED: [[SimpleTest]]: [MySQL] 55,611 pass(es).
[ View ]

Rerolled patch to add missing public access modifier

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Needs work

Talkes with dawehener about this, should be protected. Srry!

Status:Needs work» Needs review
StatusFileSize
new2.09 KB
new2.62 KB
PASSED: [[SimpleTest]]: [MySQL] 56,228 pass(es).
[ View ]

Changed method access to protected from public.

Status:Needs review» Reviewed & tested by the community

Thnx!

Title:Rename Views method op_regex() to addRegex()Rename Views method op_regex() to opRegex()

Changing the title to avoid confusion. op_xxx methods will be renamed to opXxxx instead of addXxx

Title:Rename Views method op_regex() to opRegex()Change notice: Rename Views method op_regex() to opRegex()
Project:Drupal core» Views
Version:8.x-dev» 8.x-3.x-dev
Component:views.module» Code
Status:Reviewed & tested by the community» Active
Issue tags:+Needs change record

Noticed these op_XX functions are all missing doxygen, but xjm told me that's getting taken care of as part of #1856544: [META] Views documentation improvements.

Committed and pushed to 8.x. Thanks!

Moving to Views for the change notice.

Title:Change notice: Rename Views method op_regex() to opRegex()Rename Views method op_regex() to opRegex()
Project:Views» Drupal core
Version:8.x-3.x-dev» 8.x-dev
Component:Code» views.module
Status:Active» Fixed
Issue tags:-Needs change record

We'll create a single change notice in the meta.

Automatically closed -- issue fixed for 2 weeks with no activity.