Files: 
CommentFileSizeAuthor
#13 views-rename_op_contains-2003554-13.patch1.72 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 55,829 pass(es).
[ View ]
#12 views-rename_op_starts-2003554-12.patch1.68 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 56,081 pass(es).
[ View ]
#10 views-rename_op_stars-2003554-10.patch1.69 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 55,968 pass(es).
[ View ]
#9 views-rename_op_contains-2003554-9.patch1.95 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 56,358 pass(es).
[ View ]
#7 views-rename_op_contains-2003554-7.patch1.71 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 57,594 pass(es).
[ View ]
#4 views-rename_op_contains_to_addContains-2003554-4.patch1.71 KBJeroenT
FAILED: [[SimpleTest]]: [MySQL] 57,408 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#2 Rename_Views_method-2003554-2.patch1.7 KBNonProfit
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

Assigned:Unassigned» NonProfit

Assigned:NonProfit» Unassigned
Status:Active» Needs review
StatusFileSize
new1.7 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Patch created.

Status:Needs review» Needs work

The last submitted patch, Rename_Views_method-2003554-2.patch, failed testing.

StatusFileSize
new1.71 KB
FAILED: [[SimpleTest]]: [MySQL] 57,408 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

rename method op_contains to addContains.

Status:Needs work» Needs review

rename method op_contains to addContains.

Status:Needs review» Needs work

The last submitted patch, views-rename_op_contains_to_addContains-2003554-4.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new1.71 KB
PASSED: [[SimpleTest]]: [MySQL] 57,594 pass(es).
[ View ]

Rename op_contains() to opContains. This is the right one.

Title:Rename Views method op_contains() to addContains()Rename Views method op_contains() to opContains()
Status:Needs review» Needs work

Should be protected

Status:Needs work» Needs review
StatusFileSize
new1.95 KB
PASSED: [[SimpleTest]]: [MySQL] 56,358 pass(es).
[ View ]

Rename op_contains to opContains. Added protected access modifier as mentioned by dawehner.

StatusFileSize
new1.69 KB
PASSED: [[SimpleTest]]: [MySQL] 55,968 pass(es).
[ View ]

Wrong patch. Sorry!

Nope #9 was the right patch ;)

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/Combine.phpundefined
@@ -96,11 +96,11 @@ function opEqual($expression) {
+  ¶

Ups some whitespace appeared.

StatusFileSize
new1.68 KB
PASSED: [[SimpleTest]]: [MySQL] 56,081 pass(es).
[ View ]

Ignore this patch. Sorry!

StatusFileSize
new1.72 KB
PASSED: [[SimpleTest]]: [MySQL] 55,829 pass(es).
[ View ]

This is the right one! :)

Status:Needs review» Reviewed & tested by the community

Looking good

Status:Reviewed & tested by the community» Fixed

Committed ee9bb51 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.