Files: 
CommentFileSizeAuthor
#4 date-format-2003942-4.patch18.89 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 55,801 pass(es).
[ View ]
#3 date-format-2003942-3.patch19.64 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 55,885 pass(es).
[ View ]
#3 interdiff.txt6.41 KBtim.plunkett
#1 date-format-2003942-1.patch18.15 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 55,702 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new18.15 KB
PASSED: [[SimpleTest]]: [MySQL] 55,702 pass(es).
[ View ]

Okay, here's the first pass.

+++ b/core/modules/system/lib/Drupal/system/Form/DateFormatEditForm.phpundefined
@@ -0,0 +1,103 @@
+    $format_info = config('system.date')->get('formats.' . $date_format_id);

Well at least inject it.

StatusFileSize
new6.41 KB
new19.64 KB
PASSED: [[SimpleTest]]: [MySQL] 55,885 pass(es).
[ View ]

StatusFileSize
new18.89 KB
PASSED: [[SimpleTest]]: [MySQL] 55,801 pass(es).
[ View ]

That went in, this is done I think.

Status:Needs review» Reviewed & tested by the community

+++ b/core/modules/system/lib/Drupal/system/Form/DateFormatFormBase.phpundefined
@@ -0,0 +1,71 @@
+    $date = new DrupalDateTime();

So apparently there is already an issue to make this a service, so that's cool.

Manually tesed and reviewed. Can't find anything wrong with this.

Status:Reviewed & tested by the community» Fixed

Committed 291689a and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.