Files: 
CommentFileSizeAuthor
#20 use-entity-test-2004224-20.patch101.85 KBBerdir
PASSED: [[SimpleTest]]: [MySQL] 56,762 pass(es).
[ View ]
#13 use-entity-test-2004224-13.patch101.85 KBBerdir
PASSED: [[SimpleTest]]: [MySQL] 54,961 pass(es).
[ View ]
#13 use-entity-test-2004224-13-interdiff.txt4.37 KBBerdir
#9 interdiff.txt1.33 KBandypost
#9 use-entity-test-2004224-9.patch103.78 KBandypost
FAILED: [[SimpleTest]]: [MySQL] 55,725 pass(es), 1 fail(s), and 1 exception(s).
[ View ]
#8 interdiff.txt1.97 KBandypost
#8 2004224-entity-test-8.patch100.96 KBandypost
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]
#3 use-entity-test-2004224-3.patch103.23 KBBerdir
FAILED: [[SimpleTest]]: [MySQL] 57,248 pass(es), 1 fail(s), and 1 exception(s).
[ View ]
#3 use-entity-test-2004224-3-interdiff.txt2.08 KBBerdir
#1 use-entity-test-2004224-1.patch101.14 KBBerdir
FAILED: [[SimpleTest]]: [MySQL] 55,711 pass(es), 20 fail(s), and 15 exception(s).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new101.14 KB
FAILED: [[SimpleTest]]: [MySQL] 55,711 pass(es), 20 fail(s), and 15 exception(s).
[ View ]

First extract, let's see if I got everything I need.

Status:Needs review» Needs work

The last submitted patch, use-entity-test-2004224-1.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new2.08 KB
new103.23 KB
FAILED: [[SimpleTest]]: [MySQL] 57,248 pass(es), 1 fail(s), and 1 exception(s).
[ View ]

This should fix those tests.

Status:Needs review» Needs work
Issue tags:-sprint, -Entity Field API

The last submitted patch, use-entity-test-2004224-3.patch, failed testing.

Status:Needs work» Needs review

#3: use-entity-test-2004224-3.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+sprint, +Entity Field API

The last submitted patch, use-entity-test-2004224-3.patch, failed testing.

+++ b/core/modules/field/lib/Drupal/field/Tests/FieldTestBase.phpundefined
@@ -49,9 +49,13 @@ function _generateTestFieldValues($cardinality) {
+    entity_get_controller($entity->entityType())->resetCache(array($entity->id()));

<?php
* @deprecated Use \Drupal\Core\Entity\EntityManager::getStorageController().
*/
function
entity_get_controller($entity_type) {
  return
Drupal::entityManager()
    ->
getStorageController($entity_type);
?>

Status:Needs work» Needs review
Issue tags:+CodeSprintUA
StatusFileSize
new100.96 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]
new1.97 KB

re-roll with small changes

StatusFileSize
new103.78 KB
FAILED: [[SimpleTest]]: [MySQL] 55,725 pass(es), 1 fail(s), and 1 exception(s).
[ View ]
new1.33 KB

proper merge

Drupal\field\Tests\FormTest still broken, @Berdir I cant fix that

Yeah, that's because the method that I changed is also used there and it's used with the old entity type that's not yet NG.

One possible way to fix this would be to keep and override of that method in FormTest, with a @todo to kill it when no longer necessary.

Status:Needs review» Needs work

The last submitted patch, use-entity-test-2004224-9.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new4.37 KB
new101.85 KB
PASSED: [[SimpleTest]]: [MySQL] 54,961 pass(es).
[ View ]

Something like this. Also removing the EntityTestCache class, I don't think we need this one here.

Status:Needs review» Reviewed & tested by the community

So now it works!

Priority:Normal» Major

This is part of a critical issue and blocking the @yched's field api/typed data issue, so raising to major to give it some visibility.

This is almost critical imo, because we need #1822000: Remove Drupal\field_test\Plugin\Entity\Type\TestEntity in favor of EntityTest after that and then we can (finally) start on #1953408: Remove ArrayAccess BC layer from field config entities (which is also critical).

#13: use-entity-test-2004224-13.patch queued for re-testing.

Needs a reroll

curl https://drupal.org/files/use-entity-test-2004224-13_0.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  101k  100  101k    0     0  43713      0  0:00:02  0:00:02 --:--:-- 51861
error: patch failed: core/modules/link/lib/Drupal/link/Tests/LinkFieldTest.php:185
error: core/modules/link/lib/Drupal/link/Tests/LinkFieldTest.php: patch does not apply

Status:Reviewed & tested by the community» Needs work

Status:Needs work» Needs review
StatusFileSize
new101.85 KB
PASSED: [[SimpleTest]]: [MySQL] 56,762 pass(es).
[ View ]

Here it is.

Issue tags:+Field API NG blocker

Starting to use that tag for things we need to do to complete conversion, remove BC layer and fully convert field API to Entity Field API/Typed data.

Issue tags:-Field API NG blocker

Green, back to RTBC ?

Issue tags:+Field API NG blocker

Re-adding tag.

Status:Needs review» Reviewed & tested by the community

Yeah, meant to do that in #22, but instead I removed the tag :-D Sorry folks.
Let's get this in !

#20: use-entity-test-2004224-20.patch queued for re-testing.

Status:Reviewed & tested by the community» Fixed

Committed bf2c404 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.