Posted by xjm

Problem/Motivation

The test filter plugin in core/modules/filter/tests/filter_test/lib/Drupal/filter_test/Plugin/Filter/FilterTestReplace.php uses the wrong case for getPluginId():

<?php
    $text
[] = 'Filter: ' . $this->getLabel() . ' (' . $this->getPluginID() . ')';
?>

While function names are (apparently) not case sensitive in PHP (@alexpott looked this up) and "Id" is a different word from "ID", we should nonetheless use the same case as the method defined on PluginBase.

Proposed resolution

Rename FilterTestReplace::getPluginID() to getPluginId().

Files: 
CommentFileSizeAuthor
#2 filters-method-name-getPluginId-7461444-2.patch894 bytesbrentaar
PASSED: [[SimpleTest]]: [MySQL] 55,673 pass(es).
[ View ]

Comments

Assigned:Unassigned» brentaar

Status:Active» Needs review
StatusFileSize
new894 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,673 pass(es).
[ View ]

Assigned:brentaar» Unassigned

Everything looks good.

Status:Needs review» Reviewed & tested by the community

Thanks @brentaar!

Status:Reviewed & tested by the community» Fixed

Committed 4074668 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

Removing myself from the author field to unfollow the issue. --xjm