Project Page: http://drupal.org/sandbox/DannyN-1/2004708
GIT Repo: git clone --branch master http://git.drupal.org:sandbox/DannyN-1/2004708.git
DESCRIPTION
-----------
A powerful module to display different content based on the browsing device.
Mobile Content module allows content administrator to tag sections of content to be displayed on mobile devices. Tag format should be {mobile}...{/mobile}.
INSTALLATION
------------
1. CREATE DIRECTORY
Create a new directory "mobile_content" in the sites/all/modules directory and
place the entire contents of this mobile_content folder in it.
2. ENABLE THE MODULE
Enable the module on the Modules admin page.
USAGE
-----------
Edit a content type and wrap any text to be displayed on mobile devices using {mobile}....{/mobile} tags.
Example, if you entered the following when editing the body of a node:
{mobile}Drupal is an open source content management platform{/mobile} powering millions of websites and applications. It’s built, used, and {mobile}supported by an active and diverse community{/mobile} of people around the world
The content when viewed from Desktop will be displayed as:
Drupal is an open source content management platform powering millions of websites and applications. It’s built, used, and supported by an active and diverse community of people around the world
The same content when viewed from a mobile device will be displayed as:
Drupal is an open source content management platform supported by an active and diverse community
Comments
Comment #1
klausiYou need to set the status to "needs review" if you want to get a review, see https://drupal.org/node/532400
Comment #2
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxDannyN-12004708git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
TimTheEnchanter commentedYou will need to switch from master to a major branch version https://drupal.org/empty-git-master
You will also want to check the automated review http://ventral.org/pareview/httpgitdrupalorgsandboxdannyn-12004708git
There are a lot of issues related to whitespace, indentation, syntax, etc. Check the coding standard here https://drupal.org/coding-standards
As far as the module itself, usually when loading 3rd party libraries, as you have in this module with the mobile detect script, usually module authors include it in the library api. https://drupal.org/project/libraries The reason for this is stated on that page pretty well so I will quote it
There is a project that does this with the same library https://drupal.org/project/mobile_detect You could either make your module depend on that module to ensure the library is included, or use their example to code your module.
Also including a help hook is always nice https://api.drupal.org/api/drupal/modules%21help%21help.api.php/function...
Comment #4
PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #5
DannyN commentedre-opening
Comment #6
DannyN commentedI will be reviewing and committing changes over the next few days
Comment #7
klausiOk, please set this to "needs review" once you are ready. see https://drupal.org/node/532400
Comment #8
PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.