I think the module should include Simple Tests to ensure that any patches submitted don't break module features.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

johnennew’s picture

Status: Active » Needs review
FileSize
13.47 KB

Please find some initial tests attached for review. These test the default workings of the module. I'll look at adding role based tests if these are accepted.

johnennew’s picture

Another testing patch with additional tests for role and user session limit.

deekayen’s picture

Status: Needs review » Fixed

Added to 7.x-2.x in 977e154.

johnennew’s picture

Version: 7.x-2.x-dev » 6.x-2.x-dev
Status: Fixed » Needs review
FileSize
19.63 KB

Simple tests back ported to 6.x-2.x branch

Status: Needs review » Needs work

The last submitted patch, session_limit-add_simpletests-2005782-7469308.patch, failed testing.

johnennew’s picture

Status: Needs work » Needs review
FileSize
19.62 KB

Removed devel code, trying again ...

johnennew’s picture

Status: Needs review » Fixed

Tests pass - committing to 6.x-2.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.