The installer could become a bit more user friendly, if there was a 'go back' button allowing to change at least locale and install profile. This should be possible during the first tasks until the real database installation takes place and is only blocked by #2004682: On install, download .po file to temp directory. Until then, "save" button should then also just say "continue".
Comment | File | Size | Author |
---|---|---|---|
#4 | install_back_and_forth_2006878-4.patch | 3.67 KB | Pancho |
#1 | install_back_and_forth_2006878-1.patch | 3.14 KB | Pancho |
Comments
Comment #1
PanchoHere's a working patch.
The styling issue of the two buttons in a row is due to the CSS rule:
which I'm not sure is correct anyway. Will follow up on this.
If that's fixed, we will also need a usability review.
Comment #3
PanchoRegarding the CSS issue, it's not all that obvious what needs to change:
update.php uses the submit buttons without a 'form-actions' wrapper. Probably it shouldn't but that's why there is this CSS rule.
We should streamline it here and there, but which way we do needs to be decided, both UI-wise and technically.
So let's start with the usability side. When disabling this CSS rule it now looks like this:
Apart from the button size I think that this is pretty nice.
Comment #4
PanchoAs a stop-gap measure, I'm manually overwriting the "display: block" CSS rule. Can be removed later.
Also, adding some 'alt' tags to all buttons to improve accessibility - this needs an accessibility review as well.
Might still need some simpletest adjustments because the button values have been changed. We'll see what the testbot says.
Screenshot in #3 still applies, in any case.
Comment #6
Bojhan CreditAttribution: Bojhan commentedThis kind of looks and feels awful, I dont think there is a demonstrated need for this either. You can only go back to changing your site-name and the language?
Comment #7
mgiffordNo longer appies.
Comment #8
Bojhan CreditAttribution: Bojhan commentedThis doesn't need a reroll, we shouldn't have something this awful in core.