The installer could become a bit more user friendly, if there was a 'go back' button allowing to change at least locale and install profile. This should be possible during the first tasks until the real database installation takes place and is only blocked by #2004682: On install, download .po file to temp directory. Until then, "save" button should then also just say "continue".

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pancho’s picture

Status: Active » Needs review
FileSize
3.14 KB

Here's a working patch.
The styling issue of the two buttons in a row is due to the CSS rule:

body.in-maintenance .form-submit {
    display: block;
}

which I'm not sure is correct anyway. Will follow up on this.
If that's fixed, we will also need a usability review.

Status: Needs review » Needs work

The last submitted patch, install_back_and_forth_2006878-1.patch, failed testing.

Pancho’s picture

Status: Needs work » Needs review
Issue tags: +Needs usability review
FileSize
20.95 KB

Regarding the CSS issue, it's not all that obvious what needs to change:
update.php uses the submit buttons without a 'form-actions' wrapper. Probably it shouldn't but that's why there is this CSS rule.
We should streamline it here and there, but which way we do needs to be decided, both UI-wise and technically.

So let's start with the usability side. When disabling this CSS rule it now looks like this:
Screenshot
Apart from the button size I think that this is pretty nice.

Pancho’s picture

As a stop-gap measure, I'm manually overwriting the "display: block" CSS rule. Can be removed later.
Also, adding some 'alt' tags to all buttons to improve accessibility - this needs an accessibility review as well.
Might still need some simpletest adjustments because the button values have been changed. We'll see what the testbot says.
Screenshot in #3 still applies, in any case.

Status: Needs review » Needs work

The last submitted patch, install_back_and_forth_2006878-4.patch, failed testing.

Bojhan’s picture

Issue tags: -Needs usability review

This kind of looks and feels awful, I dont think there is a demonstrated need for this either. You can only go back to changing your site-name and the language?

mgifford’s picture

Issue summary: View changes
Issue tags: +Needs reroll

No longer appies.

Bojhan’s picture

Status: Needs work » Closed (won't fix)

This doesn't need a reroll, we shouldn't have something this awful in core.