[D7] Icecat for Drupal commerce

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxtortelduif1992168git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Attempt to clone Git repository:
host@ubuntu:~/workspace/review$ git clone http://drupalcode.org/sandbox/tortelduif/1992168.git
Cloning into '1992168'...
fatal: http://drupalcode.org/sandbox/tortelduif/1992168.git/info/refs not valid: is this a git repository?

Automated review works perfectly
http://ventral.org/pareview/httpgitdrupalorgsandboxtortelduif1992168git

May be something's wrong wit the client part of Git.
Assigning 'needs review'.

Hi

PAReview script detected 1 minor code style issue, see http://ventral.org/pareview/httpgitdrupalorgsandboxtortelduif1992168git.

Please, take a look at the tips for a great project page.

Manual review:

• icecat.module, line 109: there's a declared and unused variable $type.
• icecat.module, line 174: you should use a theme('image', ...) instead of manually typing img tag. See:
  

      if (isset($nodes[$nid]['icecat_image'])) {
        $image = '<img src="' . $nodes[$nid]['icecat_image'] . '">';
      }
  

• icecat.module, line 298: there's an undefined variable $data.
• icecat.module, line 292, 296, 299: it is advised to use the url() function to form a URL. There will be no need to use str_replace() on the line 303. See:
  

    if ($icecat_brand && $icecat_sku) {
      $url = 'http://' . $auth . 'data.icecat.biz/xml_s3/xml_server3.cgi?prod_id=' . $icecat_sku . ';lang=' . $language . ';output=productxml;vendor=' . $icecat_brand . ';';
    }
    elseif ($icecat_sku || $icecat_ean) {
      if ($icecat_sku <> 0 && $icecat_sku) {
        $url = 'http://' . $auth . 'data.icecat.biz/xml_s3/xml_server3.cgi?ean_upc=' . $icecat_sku . ';lang=' . $language . ';output=productxml;';
      }
      if ($data == FALSE) {
        $url = 'http://' . $auth . 'data.icecat.biz/xml_s3/xml_server3.cgi?ean_upc=' . $icecat_ean . ';lang=' . $language . ';output=productxml;';
      }
    }
    if (isset($url)) {
      $url = str_replace(' ', '%20', $url);
  

Regards

Hi

1. Your comments have not the right syntaxe.
You write

/**
 * Hook_menu.
 */

but you should write :

/**
 * Implements hook_menu().
 */

You have this problème on icecat.module :

• l.7 views api
• l. 17 menu
• l.53 node form alter
• l.197 node_load
• l.229 node insert
• l.249 node update
• l.270 node delete

2. Make also sure, you have a line break after you declaration of function.
Example : l.282 of icecat.module : you have to add a clear line before the next declaration.

3. Another thing, you are not using t() function. All description, or text available for human (admin or simple user) must be translated on another language.
Ex : icecat.module l.29 'Select icecat settings' must be t('Select icecat settings')

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.