Make the Video.js module 6.x-2.x compatible with the latest 3.2.x release of the Video.js library (3.2.3)

typo fixed

It turned out that the latest 6.x-2.x release of the Video.js module - version 6.x-2.3 - is only compatible with version 3.2.0 of the Video.js library, due to this change in 3.2.1.

The attached patch fixes the issue. It makes the module version 6.x-2.x compatible with all current 3.2.x versions of the Video.js library, so you can use either 3.2.0 or the latest 3.2.3.

Thank you for committing changes based on my patch. However, the way you have committed it won't work.

The "data-setup" attribute can contain any options the Video.js library understands and must be in JSON format. JSON only accepts double-quotes as quotes (no single quotes!). Thus we must use the following notation:

data-setup='{
"width": <?php echo $width ?>,
"height": <?php echo $height ?>,
}'

and NOT

data-setup="{
'width': <?php echo $width ?>,
'height': <?php echo $height ?>,
}"

as you committed it. I also don't understand why you changed my easy-to-read-and-expand multi-line format as shown above to the hard-to-read-and-expand inline format

data-setup="{'width': <?php echo $width ?>, 'height': <?php echo $height ?>}"

all within the single same line of the "video" element. "width" and "height" are not the only possible options, so keeping the multi-line format with one Video.js option per line would allow users to easily add other options.

Regarding your bad feeling about the change in Video.js 3.2.1 to accept "width" and "height" as options, I think this is an improvement, but I agree with you they should have left the alternative possibility to read them directly from the HTML attributes. Now we have both ways implemented in the module (after you correct the commit), so we are just future proof and obey both pure HTML 5 and the way Video.js now prefers it.

Video.js development is currently also very active - for example, they just released 4.0.4 yesterday.

You can trust me 100% that the code you have committed does not work. Strings within the "data-setup" attribute must be in JSON (JavaScript Object Notation) format, as I already explained. JSON requires a string to be wrapped in double quotes. You have used single quotes which simply violates the specification and thus the whole string inside won't be recognized. There is no choice of preferred single/double quotes coding style - we are bound to always use double quotes for the options, and as a consequence, single quotes for the entire attribute value, so until you change it the commit will have zero effect.

Thanks for correcting it - now it looks and works perfectly.