The default view for the list of cards shown on the user profile is an "unformatted list", which I would assume on 80% of users won't be styled in a way that's usable "out of the box" with out some CSS love. I noticed you have no attached classes to this view, and there's no CSS in this module, so I can't imagine it supposed to pick up a theme from something like commerce kickstart, although I could be wrong.
The easiest way to make this page usable by most themes would be unfortunately to display it in a table. Any user who wants to change it back and add some CSS love to an unformatted list after that is welcome to, but at least out of the box with any theme which styles a table, it should look and be usable out of the box.
Attached is the view I created and exported.
Comment | File | Size | Author |
---|---|---|---|
#6 | default_user_cc_view-2007646-6.patch | 15.83 KB | deggertsen |
cardonfile_expored_view.txt | 11.24 KB | j0rd |
Comments
Comment #1
dwkitchen CreditAttribution: dwkitchen commentedI've had it as both as I have been doing the work on the module.
As we have gone for tables in Commerce Recurring, I will probably go for a table here to.
Comment #2
micheas CreditAttribution: micheas commentedA warning, Last I checked. tables are generally an order of magnitude slower to be processed by javascript, so swapping out a list with a table could be the difference between an acceptable and unacceptable mobile experience.
Comment #3
j0rd CreditAttribution: j0rd commentedThe current experience is unusable on any browser, as the information is displayed makes little sense to the end user.
Turning the view into a table by default solves this problem with minimal work. Should a site owner require a better mobile experience after that, then they could override the view. Additionally since most themes have tables styled in a reasonable fashion, this change gets this form auto styled on most sites.
Personally think point raised in #2 is not worth holding back this change.
Comment #4
deggertsen CreditAttribution: deggertsen commentedSeems like a good idea to me. The current default view is pretty bad. I vote that this gets committed as it will most certainly be an improvement over what we have now.
Comment #5
mesch CreditAttribution: mesch commented+1 for this change.
Comment #6
deggertsen CreditAttribution: deggertsen commentedI went ahead and created a patch out of this view change so that it can actually get committed. I made a few minor modifications that are mostly case changes so that the patch wouldn't make any unnecessary modifications.
Seeing as others have already looked at this view change I am marking as RTBC.
Comment #7
bojanz CreditAttribution: bojanz commentedCommitted, thanks.