use hook_field_access() to hide fields of exiting entities [#2007746]

If using #access = FALSE on the form, after ajax requests (e.g. remove image), groups can be gone.

Comment	File	Size	Author
#5	2007746-er-hide-access-5.patch	865 bytes	amitaibu
#5
#3	field_access_breaks_create_with_hide-2007746-3.patch	634 bytes	rbrandon
#3
#1	2007746-er-prepopulate-hide-field-1.patch	2 KB	amitaibu
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 30 May 2013 at 07:53

Status:

Active

» Needs review

File	Size
2007746-er-prepopulate-hide-field-1.patch	2 KB

Comment #2

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 30 May 2013 at 08:17

Status:

Needs review

» Fixed

Committed.

Comment #3

rbrandon CreditAttribution: rbrandon commented 31 May 2013 at 15:00

Status:

Fixed

» Needs review

File	Size
field_access_breaks_create_with_hide-2007746-3.patch	634 bytes

The above patch breaks node creation when hiding fields.
Not sure if this is the correct longterm solution but this fixes the issue in both scenarios.

-RB

Comment #4

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 31 May 2013 at 17:35

> The above patch breaks node creation when hiding fields.

I wasn't able to reproduce on a clean installation, what are the steps?

+++ b/entityreference_prepopulate.moduleundefined
@@ -153,7 +153,7 @@ function entityreference_prepopulate_field_access($op, $field, $entity_type, $en
+    return ($settings['action'] == 'hide' && empty($entity->is_new)) ? FALSE : NULL;

I'm not clear about this fix, as we are already inside if ($id) which means this entity is already saved.