Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As of PHP 5.4.0 call-time pass by reference causes fatal error, see Passing by Reference.
Both brightcove_media and brightcove_field modules feature call-time pass by reference calls to _brightcove_upload_form() causing fatal errors.
Comment | File | Size | Author |
---|---|---|---|
#8 | brightcove-remove-more-refs-2007994-8.patch | 2.02 KB | sheldonkreger |
#7 | brightcove-remove-more-refs-2007994-7.patch | 0 bytes | sheldonkreger |
#4 | brightcove-pass-by-ref-2007994-4.patch | 3.16 KB | claudiu.cristea |
#2 | brightcove-pass-by-ref-2007994-1.patch | 3.62 KB | gabidrg |
#1 | brightcove-passbyref-2007994-1.patch | 1.76 KB | gabidrg |
Comments
Comment #1
gabidrg CreditAttribution: gabidrg commentedProviding patch file.
Comment #2
gabidrg CreditAttribution: gabidrg commentedUpdated patch.
Comment #3
claudiu.cristeaRTBC
Comment #4
claudiu.cristeaChanged patch from #2 because there's no need to change the
$file
as reference from the last line. In that particular case the variable$file
is a simple reference to an array item.Comment #5
k.dani CreditAttribution: k.dani commentedThank you for the patch, it has been added to 7.x-4.x-dev.
Comment #7
sheldonkreger CreditAttribution: sheldonkreger commentedI found more of them and removed them.
Comment #8
sheldonkreger CreditAttribution: sheldonkreger commentedPrevious file was blank, apologies.
Comment #9
k.dani CreditAttribution: k.dani commentedThanks for the patch, sheldonkreger, I've added to dev.
Comment #10
hairqles CreditAttribution: hairqles commented