As of PHP 5.4.0 call-time pass by reference causes fatal error, see Passing by Reference.

Both brightcove_media and brightcove_field modules feature call-time pass by reference calls to _brightcove_upload_form() causing fatal errors.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gabidrg’s picture

Status: Active » Needs review
FileSize
1.76 KB

Providing patch file.

gabidrg’s picture

Updated patch.

claudiu.cristea’s picture

Status: Needs review » Reviewed & tested by the community

RTBC

claudiu.cristea’s picture

Changed patch from #2 because there's no need to change the $file as reference from the last line. In that particular case the variable $file is a simple reference to an array item.

k.dani’s picture

Assigned: gabidrg » k.dani
Status: Reviewed & tested by the community » Fixed

Thank you for the patch, it has been added to 7.x-4.x-dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

sheldonkreger’s picture

Assigned: k.dani » Unassigned
Status: Closed (fixed) » Needs review
FileSize
0 bytes

I found more of them and removed them.

sheldonkreger’s picture

Previous file was blank, apologies.

k.dani’s picture

Status: Needs review » Fixed

Thanks for the patch, sheldonkreger, I've added to dev.

hairqles’s picture

Status: Fixed » Closed (fixed)