I'm using the Feeds 7.x-2.x branch (7e6679d) and the Features 7.x-2.x branch (8a3d404). At this time the Features dev version is equivalent to 7.x-2.0-rc1.

The issue I'm having is in regards to the feeds_news feature.

Features now separates fields into field_base and field_instance. There is more on this topic here: http://www.phase2technology.com/blog/new-field-bases-and-instances-in-fe... . I'm not exactly sure at this point what would be required, with the exception of a different branch, to check the features version and adjust the feature accordingly. I'm curious if this is something that is being considered at this point? If not, that's okay. I'm not using feeds_news just yet but may upload a patch for the feature as reference just to keep it from being overridden. If anyone has a better solution please let me know.

NOTE: Being this is a feature I would just patch it in my own code base but for those of us that have our code under version control (git) and we don't store contrib modules but rather use a make file...this is an issue without uploading a patch and adding that patch to the make file.

Thanks

CommentFileSizeAuthor
#3 2008168-3.patch14.66 KBJeroenT
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

twistor’s picture

Title: Feeds (feed_news) and Features 7.x-2.x » Update included Feeds News Feature.
Component: Code » Feeds News (feature)
Assigned: Unassigned » twistor
Category: Feature request » Task
Issue summary: View changes
MegaChriz’s picture

Issue tags: +Novice

I think anyone that has experience with features can pick this up, so tagging this as a novice issue.

JeroenT’s picture

Assigned: twistor » Unassigned
Status: Active » Needs review
FileSize
14.66 KB

I don't know if twistor is still working on this issue, but I Installed the feeds_news module, I recreated the feature and made a patch of the changes.

Patch attached.

MegaChriz’s picture

Status: Needs review » Reviewed & tested by the community

Looks good. I inspected the changes, especially the transition from field to field_base and field_instance and I saw no information got lost and no unnecessary extra metadata was added. The changes in the default View were harder to judge, but I think they are good since the old default View seems to been made against Views 3.0-alpha1. I also installed the Feeds News feature and walked through all the settings page and I saw nothing unsuspicious. Finally, the feature no longer appears overridden, which was the initial motivation of this issue.

RTBC to me.

  • twistor committed a6abe50 on authored by JeroenT
    Issue #2008168 by JeroenT | scottalan: Update included Feeds News...
twistor’s picture

Status: Reviewed & tested by the community » Fixed

Sounds good to me.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.