Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I stumbled across a @todo saying to remove some code once #1822458: Move dynamic parts (view modes, bundles) out of entity_info() was fixed. That issue is fixed, so here's that removal.
Comment | File | Size | Author |
---|---|---|---|
#4 | entity_bundle_info-no_alter-4.patch | 3.79 KB | effulgentsia |
entity_bundle_info-no_alter.patch | 3.78 KB | effulgentsia | |
Comments
Comment #1
andypostwhere is the removal of @todo in a patch? looks nice clean-up
Comment #2
tim.plunkettRight here.
I remember hitting that field_test_module_implements_alter() when converting this, I don't know why I didn't just remove it. Thanks @effulgentsia!
If it passes we're good here.
Comment #3
alexpottNeeds a reroll...
Comment #4
effulgentsia CreditAttribution: effulgentsia commentedStraight reroll. Leaving at RTBC.
Comment #5
alexpottCommitted bd6ad51 and pushed to 8.x. Thanks!