Problem/Motivation

We have a page for error settings. But the error pages are set on the system information page. This is non-intuitive.

Proposed resolution

We should move the error settings to the error settings page.

Remaining tasks

  • Move the settings for Default 403 (access denied) page and Default 404 (not found) page to admin/config/development/logging

User interface changes

Two form fields move from a strange place to a sensical place.

API changes

None.

CommentFileSizeAuthor
#13 drupal-8.x-moved_error_pages_setting_to_better_location_2008718-13.patch16.71 KBVladSavitsky
#13 interdiff.txt8.82 KBVladSavitsky
#10 interdiff.txt20.87 KBVladSavitsky
#9 drupal-8.x-moved_error_pages_setting_to_better_location_2008718-7.patch24.68 KBVladSavitsky
#5 moved_error_pages_setting_to_better_location_2008718-5.patch12.61 KBVladSavitsky
#4 moved_error_pages_setting_to_better_location_2008718-4.patch9.57 KBVladSavitsky
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Issue tags: +Novice

tagging.

VladSavitsky’s picture

VladSavitsky CreditAttribution: VladSavitsky commented
Assigned: Unassigned » VladSavitsky
Issue tags: +CodeSprintUA

We are working today with this issue during Code Sprint UA

VladSavitsky’s picture

VladSavitsky CreditAttribution: VladSavitsky commented
Status: Active » Needs work
VladSavitsky’s picture

VladSavitsky CreditAttribution: VladSavitsky commented
Status: Needs work » Needs review
FileSize
moved_error_pages_setting_to_better_location_2008718-4.patch9.57 KB
VladSavitsky’s picture

VladSavitsky CreditAttribution: VladSavitsky commented
FileSize
moved_error_pages_setting_to_better_location_2008718-5.patch12.61 KB

Updated tests to reflect changes in code.

VladSavitsky’s picture

VladSavitsky CreditAttribution: VladSavitsky commented

This patch fails tests and need some work.

Status: Needs review » Needs work

The last submitted patch, moved_error_pages_setting_to_better_location_2008718-5.patch, failed testing.

VladSavitsky’s picture

VladSavitsky CreditAttribution: VladSavitsky commented

@System Message, thank you that you spent your time for testing but I wrote above that this patch needs more work :)

VladSavitsky’s picture

VladSavitsky CreditAttribution: VladSavitsky commented
FileSize
drupal-8.x-moved_error_pages_setting_to_better_location_2008718-7.patch24.68 KB

This version changes all places where page.403 and page.404 were used and I'm sure will pass all tests because it passed tests at local machine.

VladSavitsky’s picture

VladSavitsky CreditAttribution: VladSavitsky commented
FileSize
interdiff.txt20.87 KB

Here is a diff for latest patch against previous one.

VladSavitsky’s picture

VladSavitsky CreditAttribution: VladSavitsky commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, drupal-8.x-moved_error_pages_setting_to_better_location_2008718-7.patch, failed testing.

VladSavitsky’s picture

VladSavitsky CreditAttribution: VladSavitsky commented
FileSize
interdiff.txt8.82 KB
drupal-8.x-moved_error_pages_setting_to_better_location_2008718-13.patch16.71 KB

Fixed tests which failed.

VladSavitsky’s picture

VladSavitsky CreditAttribution: VladSavitsky commented
Status: Needs work » Needs review
Issue tags: -Usability, -Novice
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Reviewed & tested by the community

Awesome!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work

Hmmm... I'm not sure that we should be moving the keys to system.logging.yml ... I'm okay with them moving config page but moving config file not really...

But if you are moving them from system.site.yml to system.logging.yml you need to update the default files in the system/config and you need to update the schema in system/config/schema

Also...

+++ b/core/modules/system/lib/Drupal/system/Form/LoggingForm.phpundefined
@@ -38,8 +76,52 @@
+      '#field_prefix' => url(NULL, array('absolute' => TRUE)),
...
+      '#field_prefix' => url(NULL, array('absolute' => TRUE)),

We can now inject the url_generator service!

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.