Part of #2006152: [meta] Don't call theme() directly anywhere outside drupal_render().

CommentFileSizeAuthor
#9 replace_theme_function_with_drupal_render_in_filter_module-2009018-9.patch1.16 KBStephaneQ
#3 replace_theme_function_with_drupal_render_in_user_module-2009690-3.patch2.69 KBInternetDevels
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Issue tags: +Novice
InternetDevels’s picture

InternetDevels CreditAttribution: InternetDevels commented
Assigned: Unassigned » InternetDevels

We are working today with this issue during Code Sprint UA.

InternetDevels’s picture

InternetDevels CreditAttribution: InternetDevels commented
Assigned: InternetDevels » Unassigned
Status: Active » Needs review
FileSize
replace_theme_function_with_drupal_render_in_user_module-2009690-3.patch2.69 KB

Patch attached.

InternetDevels’s picture

InternetDevels CreditAttribution: InternetDevels commented
Issue tags: +CodeSprintUA
thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -CodeSprintUA

This looks ok to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed b61918f and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Status: Closed (fixed) » Needs work

There is still a theme() call in FilterCaption.php

StephaneQ’s picture

StephaneQ
Primary language French
Location Paris 🇫🇷
CreditAttribution: StephaneQ commented
Status: Needs work » Needs review
FileSize
replace_theme_function_with_drupal_render_in_filter_module-2009018-9.patch1.16 KB
siccababes’s picture

siccababes CreditAttribution: siccababes commented
Status: Needs review » Reviewed & tested by the community

I created an article and it worked fine.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

#9: replace_theme_function_with_drupal_render_in_filter_module-2009018-9.patch queued for re-testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

C14N(), eh? And the award for the silliest method name goes to... :D

At any rate, this does seem indeed to just be taking what's there and moving it to a drupal_render() call, so...

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.