Replace theme() with drupal_render() in rdf module [#2009664]

Comment	File	Size	Author
#19	rdf-replace_theme-2009664-19.patch	1.45 KB	hussainweb

#17	rdf-replace_theme-2009664-15.patch	1.45 KB	JeroenT

#15	rdf-replace_theme-2009664-15.patch	1.45 KB	JeroenT

#12	drupal_replace_theme_with_drupal_render_rdf_module-2009664-12.patch	1.41 KB	esunger

#11	drupal_replace_theme_with_drupal_render_rdf_module-2009664-11.patch	1.41 KB	esunger

#9	drupal_replace_theme_with_drupal_render_rdf_module-2009664-9.patch	1.38 KB	esunger

#7	drupal_replace_theme_with_drupal_render_rdf_module-2009664-7.patch	3.4 KB	esunger

#3	drupal_replace_theme_with_drupal_render_rdf_module-2009664-3.patch	1.38 KB	esunger

#1	2009664-replace_theme_with_drupal_render_in_rdf-1.patch	824 bytes	aaronott

File	Size
2009664-replace_theme_with_drupal_render_in_rdf-1.patch	824 bytes

Comment #3

esunger CreditAttribution: esunger commented 2 June 2013 at 11:40

File	Size
drupal_replace_theme_with_drupal_render_rdf_module-2009664-3.patch	1.38 KB

New version of the patch with added missed drupal_render() functions.

Log in or register to post comments

Comment #4

esunger CreditAttribution: esunger commented 2 June 2013 at 11:46

Status:

Active

» Needs review

Log in or register to post comments

Comment #5

esunger CreditAttribution: esunger commented 2 June 2013 at 11:48

Issue tags:

+CodeSprintUA

Log in or register to post comments

Comment #6

3 June 2013 at 02:26

Status:

Needs review

» Needs work

The last submitted patch, drupal_replace_theme_with_drupal_render_rdf_module-2009664-3.patch, failed testing.

Log in or register to post comments

File	Size
drupal_replace_theme_with_drupal_render_rdf_module-2009664-7.patch	3.4 KB

Comment #8

esunger CreditAttribution: esunger commented 3 June 2013 at 07:59

Status:

Needs work

» Needs review

Log in or register to post comments

File	Size
drupal_replace_theme_with_drupal_render_rdf_module-2009664-9.patch	1.38 KB

Comment #10

podarok

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 3 June 2013 at 13:24

Status:

Needs review

» Needs work

+++ b/core/modules/rdf/rdf.moduleundefined
@@ -461,7 +461,13 @@ function rdf_process(&$variables, $hook) {
+      $variable = array(
+	'#theme' => 'rdf_template_variable_wrapper',
+	'#content' => $variables[$variable_name],
+	'#attributes' => $attributes,
+	'#context' => $context,

https://drupal.org/coding-standards#indenting
Indenting errors

Log in or register to post comments

Comment #11

esunger CreditAttribution: esunger commented 3 June 2013 at 14:51

Status:

Needs work

» Needs review

File	Size
drupal_replace_theme_with_drupal_render_rdf_module-2009664-11.patch	1.41 KB

Thanks. Indenting errors were solved.

Log in or register to post comments

File	Size
drupal_replace_theme_with_drupal_render_rdf_module-2009664-12.patch	1.41 KB

Comment #13

podarok

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 3 June 2013 at 19:05

Status:

Needs review

» Reviewed & tested by the community

#12 looks good for me
if bot green - rtbc

Log in or register to post comments

Comment #14

3 June 2013 at 19:58

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, drupal_replace_theme_with_drupal_render_rdf_module-2009664-12.patch, failed testing.

Log in or register to post comments

Comment #15

JeroenT

Dutch

🇧🇪

CreditAttribution: JeroenT commented 9 June 2013 at 12:13

Status:

Needs work

» Needs review

File	Size
rdf-replace_theme-2009664-15.patch	1.45 KB

Replaced theme with drupal_render

Log in or register to post comments

Comment #16

thedavidmeister CreditAttribution: thedavidmeister commented 16 June 2013 at 04:26

Status:

Needs review

» Needs work

+ '#metadata' => $variables['rdf_metadata_attributes']

missing a trailing comma on this line.

Log in or register to post comments

Comment #17

JeroenT

Dutch

🇧🇪

CreditAttribution: JeroenT commented 16 June 2013 at 08:02

Status:

Needs work

» Needs review

File	Size
rdf-replace_theme-2009664-15.patch	1.45 KB

Added trailing comma.

Log in or register to post comments

Comment #18

thedavidmeister CreditAttribution: thedavidmeister commented 17 June 2013 at 10:45

Status:

Needs review

» Needs work

+ '#metadata' => $variables['rdf_metadata_attributes']

Still no trailing comma in #17

Log in or register to post comments

Comment #19

hussainweb

English

CreditAttribution: hussainweb commented 17 June 2013 at 11:30

Status:

Needs work

» Needs review

File	Size
rdf-replace_theme-2009664-19.patch	1.45 KB

Added a trailing comma and made sure it applies against the latest tree.

Log in or register to post comments

Comment #20

sbudker1 CreditAttribution: sbudker1 commented 18 June 2013 at 22:17

Status:

Needs review

» Reviewed & tested by the community

The patched worked! After inspecting the element of the submission, the rdf markup there contained normal rdf attributes. In addition the entire submission and appearance of the submission were normal.