Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Comment | File | Size | Author |
---|---|---|---|
#19 | drupal_remove_theme_shortcut-2009668-19.patch | 898 bytes | BarisW |
#19 | interdiff-10-19.txt | 807 bytes | BarisW |
#17 | empty_message_fixed-2009668-2.patch | 842 bytes | drupee |
#15 | empty_message_fixed-2009668-1.patch | 834 bytes | drupee |
#10 | empty_message_fixed-2009668.patch | 829 bytes | drupee |
Comments
Comment #1
floydm CreditAttribution: floydm commentedComment #2
thedavidmeister CreditAttribution: thedavidmeister commentedOnly indent new lines 2 spaces instead of 4 please.
Comment #3
danylevskyi#2009672: [META] CodeSprint UA 2013
Comment #4
danylevskyiComment #5
danylevskyiComment #6
podarok#5 if bot happy - rtbc
look good for me
Comment #7
alexpottCommitted 3c420a6 and pushed to 8.x. Thanks!
Comment #8
tstoecklerThis should be a top-level #empty instead, as can be seen in theme_table(). You can verify that this is currently broken when visiting admin/config/user-interface/shortcut/manage/default. Before the patch the empty message displayed, now it doesn't. Instead you will find an "empty" attribute on the < table > element.
Comment #9
thedavidmeister CreditAttribution: thedavidmeister commenteddang
Comment #10
drupee CreditAttribution: drupee commentedGood Point! I just fixed it.
Comment #11
drupee CreditAttribution: drupee commented#10: empty_message_fixed-2009668.patch queued for re-testing.
Comment #12
BarisW CreditAttribution: BarisW commentedAccording to the coding standards, shouldn't this be written like this:
Comment #13
drupee CreditAttribution: drupee commentedI refered this ,
"However, for links enclosed in translatable text you should use t() and embed the HTML anchor tag directly in the translated string. For example:
t('Visit the settings page', array('@url' => url('admin')));
This keeps the context of the link title ('settings' in the example) for translators. "
at https://api.drupal.org/api/drupal/core%21includes%21common.inc/function/l/8
can somebody please recheck.
Comment #14
BarisW CreditAttribution: BarisW commentedI meant the start of the values in the array on the next line for arrays spanning over 80 characters.
Comment #15
drupee CreditAttribution: drupee commentedOkay, thanks for explanation. I have updated the patch likewise. Please check now.
Comment #16
BarisW CreditAttribution: BarisW commentedSorry for being such an arse, but the closing brackets should be on a new line:
instead of:
It should read (mark the comma after url(),):
Comment #17
drupee CreditAttribution: drupee commentedCan you recheck now?
Comment #18
drupee CreditAttribution: drupee commentedComment #19
BarisW CreditAttribution: BarisW commentedAnd now you're missing two spaces ;)
This should nail it.
Comment #20
tstoecklerAwesome!
Comment #21
alexpottCommitted f7d8998 and pushed to 8.x. Thanks!