Problem/Motivation
If you use a breakpoint with a 16 column grid the LayoutManager won't show the columns and you're unable to configure the regions because there's no css that defines how width the columns have to be.
Proposed resolution
Attached patch removes the css and replaces it by a calculated width for all grids. Since the total columns always have to be 100% width that's a fairly easy calculation.
Further I've added a check to prevent the LayoutManager from displaying stupid breakpoint width's. It's simply to hard to configure a breakpoint <200px - thus the LayoutManager has now a min width of 250px and notices the user if this minimal width is used.
Remaining tasks
Reviews needed
User interface changes
Hopefully improvements...
Comments
Comment #1
das-peter CreditAttribution: das-peter commentedAnd here's the follow-up. Unfortunately, the regions also rely on that grid css.
As I don't know a better way to access the current number of columns of the grid in
Region.prototype.alterSpan()
I added those now as parameter :|If there's an easier way to access that information the patch would be smaller ;)
However, the approach is the same -> calculate the width as percentage.
Comment #2
das-peter CreditAttribution: das-peter commentedOoops, there was still an issue in the previous patch.
Fixed missing isRelative parameter in one of the modified calls.
Further I noticed that
LayoutStep.prototype.startRegionResize()
seems to calculate odd data.Thus I've that patched as well:
this.$editor.width()
to calculate the frame width - this is the effective value and not the "it should be like defined in the step" one ;) (Had some trouble with margins)Comment #3
das-peter CreditAttribution: das-peter commentedOh, lost my patch :|