Part of #2010184: [meta] convert ‘uri_callback’ entities param to EntityInterface::uri() method.

Needs to implement Plugin\Entity\Category.php uri() method and drop contact_category_uri() function replacing it's calls to $entity->uri() and clean-up uri_callback at entity annotation.

CommentFileSizeAuthor
#1 contact-convert_contact_category_uri-2010244-1.patch1.67 KBJeroenT
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT commented
Status: Active » Needs review
FileSize
contact-convert_contact_category_uri-2010244-1.patch1.67 KB

Converted contact_category_uri to entity->uri.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented

#1: contact-convert_contact_category_uri-2010244-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, contact-convert_contact_category_uri-2010244-1.patch, failed testing.

garphy’s picture

garphy CreditAttribution: garphy commented

As #2083615: Use links annotation for config entity URI like for content entities was committed, I think there is no more work to do here.

Maybe we should just mark as duplicate & close.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue summary: View changes
Status: Needs work » Closed (cannot reproduce)

Already fixed

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Parent issue: » #2010184: [meta] convert ‘uri_callback’ entities param to EntityInterface::uri() method