When the JSONP Prefix is set, the header should change from application/json to application/javascript

CommentFileSizeAuthor
#4 views_datasource-application_javascript_header-2010540-4.patch655 bytesyannickoo
#3 views_datasource-javascript-header-2010540-2.patch1012 bytesmakangus
#1 views_datasource-javascript-header-2010540.patch1.04 KBmakangus
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

makangus’s picture

makangus CreditAttribution: makangus commented
Status: Needs work » Needs review
FileSize
views_datasource-javascript-header-2010540.patch1.04 KB

Solution 1: Provide extra CONTENT-TYPE options for application/javascript and text/javascript

yannickoo’s picture

yannickoo
Location Berlin
CreditAttribution: yannickoo commented

application/javascript should be enough for JSONP, why did you add text/javascript?

makangus’s picture

makangus CreditAttribution: makangus commented
FileSize
views_datasource-javascript-header-2010540-2.patch1012 bytes

You are right, text/javascript is obsolete now. New patch.

yannickoo’s picture

yannickoo
Location Berlin
CreditAttribution: yannickoo commented
Status: Needs review » Reviewed & tested by the community
FileSize
views_datasource-application_javascript_header-2010540-4.patch655 bytes

Sorry but these big patches are very confusing. Just recreated it with git diff -w but yeah, RTBC :)

yannickoo’s picture

yannickoo
Location Berlin
CreditAttribution: yannickoo commented
Status: Reviewed & tested by the community » Fixed

Fixed with 0e0285e.

yannickoo’s picture

yannickoo
Location Berlin
CreditAttribution: yannickoo commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Fixed » Patch (to be ported)
yannickoo’s picture

yannickoo
Location Berlin
CreditAttribution: yannickoo commented
Status: Patch (to be ported) » Fixed

Fixed with 0c1cfb1.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.