drupal_container() is deprecated, and all calls in the overlay module need to be replaced with Drupal::service(), except for where the module_handler service is requested, which needs to be replaced with Drupal::moduleHandler() (see #1957154: Replace calls to drupal_container()->get('module_handler') service with Drupal::moduleHandler())

Files: 
CommentFileSizeAuthor
#3 2011108-overlay-drupal-service-3_0.patch3.01 KBchrisguindon
PASSED: [[SimpleTest]]: [MySQL] 57,292 pass(es).
[ View ]
#1 2011108-overlay-drupal-service-1.patch3.54 KBrbayliss
PASSED: [[SimpleTest]]: [MySQL] 56,185 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new3.54 KB
PASSED: [[SimpleTest]]: [MySQL] 56,185 pass(es).
[ View ]

Status:Needs review» Needs work
Issue tags:+Needs reroll

#1 no longer applies.

StatusFileSize
new3.01 KB
PASSED: [[SimpleTest]]: [MySQL] 57,292 pass(es).
[ View ]

Attach is a reroll of patch 2011108-overlay-drupal-service-1.patch

This is my first patch reroll so I hope all is well.

Status:Needs work» Needs review

Status:Needs review» Reviewed & tested by the community
Issue tags:-Needs reroll

Great job, @chrisguindon! I'm happy to RTBC your first reroll.

#3 looks good to me. The patch changes all instances of drupal_container() in the overlay module.

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

Status:Fixed» Closed (fixed)