Add alter for adding config translation tab [#2011332]

Comment	File	Size	Author
#6	config_translation.code_.2011332-6.patch	686 bytes	YesCT

Comment #1

YesCT CreditAttribution: YesCT commented 4 June 2013 at 04:34

Log in or register to post comments

Comment #2

YesCT CreditAttribution: YesCT commented 4 June 2013 at 04:35

hmm. maybe we add the hook in core and then use it here.

Log in or register to post comments

Comment #3

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 4 June 2013 at 06:58

Title:

add later for adding config translation tab

» Add alter for adding config translation tab

Did you mean *alter* instead of *later*? I'm not sure how we could improve on the menu creation, it is already as simple as possible. I don't believe any of the operations patches suggest implementing menu items based on operations, so we need to make do without that and do our own menu items. So I'm not sure there is anything to do here?

Log in or register to post comments

Comment #4

YesCT CreditAttribution: YesCT commented 4 June 2013 at 10:06

Status:

Active

» Closed (works as designed)

Log in or register to post comments

Comment #5

YesCT CreditAttribution: YesCT commented 5 July 2013 at 07:33

Assigned:	Unassigned	» YesCT
Status:	Closed (works as designed)	» Active

This is an @todo in the code.

config_translation.module
37-      // For pages that do not have a default tab, we need a default local task
38-      // on this level, so that the translate tab will show up.
39:      // @todo This is not very compatible with possible other alters. Look
40-      //   into other clever ways to make this happen,
41-      //   http://drupal.org/node/2011332.
42-      $items[$path . '/edit'] = array(
43-        'title' => 'Edit',
44-        'type' => MENU_DEFAULT_LOCAL_TASK,
45-        'weight' => -100,

Since this is the best we can do, taking out the @todo.