part of #2011290: [meta] standards cleanup to get ready for getting into core

Problem/Motivation

unused use statement
unused variable $depth
line line function summaries must be 80 chars or less. (core gate blocker https://drupal.org/core-gates#documentation-block-requirements)
@todo formatting https://drupal.org/node/1354#todo
Helper function...
@return needs descriptions (core gate blocker)

Proposed resolution

update according to standards
change Helper function... one line descriptions to Returns... for one line function summary should start with third person verb.
take out fun Goddamn ugly... one line function summary phrases.

Remaining tasks

patch

User interface changes

No.

API changes

No.

Files: 
CommentFileSizeAuthor
#4 config_translation.module.2011348-4.patch6.81 KBYesCT
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch config_translation.module.2011348-4.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#4 interdiff-1-4.txt499 bytesYesCT
#1 config_translation.module.2011348.1.patch6.91 KBYesCT
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch config_translation.module.2011348.1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

Assigned:YesCT» Unassigned
Status:Active» Needs review
StatusFileSize
new6.91 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch config_translation.module.2011348.1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

+++ b/config_translation.moduleundefined
@@ -417,10 +418,10 @@ function config_translation_page_alter(&$page) {
- * See http://drupal.org/node/1905152 for an upcoming API to access
- * translations easier through typed data.
+ * @todo Use API from http://drupal.org/node/1905152 to access translations
+ *   easier through typed data.

do we need to open an issue to do this now that 1905152 is fixed?

Status:Needs review» Needs work

@YesCT re #2, that was #1936186: Make use of locale API when it becomes available where we decided not to do it since it would have ended up with specialized code for some stuff. So this comment should be removed. Otherwise looks good to me.

Status:Needs work» Needs review
StatusFileSize
new499 bytes
new6.81 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch config_translation.module.2011348-4.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

removed comment.

Status:Needs review» Fixed

Looks great now, thanks, committed/pushed.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

note which are blockers to getting into core