Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.It is now in views module..should be in views_ui and since it tests RearrangeFilter it should be named as such
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | drupal-move_ViewsUITest-2012170-1.patch | 1.22 KB | ParisLiakos |
Comments
Comment #1
ParisLiakos CreditAttribution: ParisLiakos commentedComment #3
ParisLiakos CreditAttribution: ParisLiakos commented#1: drupal-move_ViewsUITest-2012170-1.patch queued for re-testing.
Comment #4
BerdirLooks good, noticed this yesterday when working on the change notice for PHPUnit, patch looks good and test is correctly listed on qa.d.o.
Comment #5
damiankloip CreditAttribution: damiankloip commentedI think we originally planned for more tests to go into this unit test. But then we moved that method to RearrangeFilter and the rest is history. I guess this is good how it is. Not sure it it makes sense to still have a unit test class that tests lots of random methods like this? Seems like if we created a new one every time we would have alot of test classes with not alot in?
Comment #6
ParisLiakos CreditAttribution: ParisLiakos commentedthats what we should do (and already do for Core and Component). a test class per file in the same location, so you know exactly where to find it
Comment #7
damiankloip CreditAttribution: damiankloip commentedYeah, how this is now is totally fine, and it's not like PHPUnit is slow :)
Comment #8
alexpottCommitted 081a59c and pushed to 8.x. Thanks!