[D7] Matchchat

Some issues:

function matchchat_uninstall()
Use variable_del() to delete variables so they will be remed from the cache and global $conf array

matcchat.module:

function matchchat_block_view($delta = '') {
  $block = array();
  switch ($delta) {
    case 'matchchat':
      $block['subject'] = '';
      $block['content'] = matchchat_block_html();
      break;
  }
  return $block;
}

As the value returned by matchchat_block_html() is put into $block['content'] you dont need to return an array containing
'content' element, just return it like this:

function matchchat_block_html() {
  $block = array();
  // We only want to display the comments if they are enabled globally.
  if (variable_get("matchchat_enable_display", 0) == 1) {
    $block = array(
      '#prefix' => '<div id="mccomments">',
      '#suffix' => '</div>',
      '#type' => 'markup',
    );
  }
  return $block;
}

<?php

Hi,

matcchat.module:

/**
 * Implements hook_init().
 */
function matchchat_init() {
  // Initialise library JS.
  drupal_add_library('matchchat', 'matchchat_js');
}

You are initialise library JS on all pages, including those for which it is not used. Initialise library only when it is actually used.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

it seems good.

manual review:

1. matchchat_install(): no need to set varibales upon installation, as you can make use of default values with variable_get() anyway.
2. matchchat_html_head_alter(): just use menu_get_object() to get the node of the current page if it exists?

But that are not blockers, so ...

Thanks for your contribution, chrisscudder!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.