drupal_container() is deprecated, and all calls in the views_ui module need to be replaced with Drupal::service(), except for where the module_handler service is requested, which needs to be replaced with Drupal::moduleHandler() (see #1957154: Replace calls to drupal_container()->get('module_handler') service with Drupal::moduleHandler())

This task a part of #2001206: Replace drupal_container() with Drupal::service()

Files: 
CommentFileSizeAuthor
#4 views-ui-2014049-4.patch1.86 KBkgoel
PASSED: [[SimpleTest]]: [MySQL] 56,997 pass(es).
[ View ]
#4 interdiff.txt1014 byteskgoel
#2 views-ui-2014049-2.patch1.86 KBkgoel
PASSED: [[SimpleTest]]: [MySQL] 55,979 pass(es).
[ View ]

Comments

Assigned:Unassigned» kgoel

Status:Active» Needs review
StatusFileSize
new1.86 KB
PASSED: [[SimpleTest]]: [MySQL] 55,979 pass(es).
[ View ]

Status:Needs review» Needs work

We should use \Drupal::request() instead \Drupal::service('request').

Status:Needs work» Needs review
StatusFileSize
new1014 bytes
new1.86 KB
PASSED: [[SimpleTest]]: [MySQL] 56,997 pass(es).
[ View ]

Status:Needs review» Reviewed & tested by the community

#4 looks good. I didn't find any more instances of drupal_container() in the views_ui module.

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

Status:Fixed» Closed (fixed)