Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The admin theme can not be managed on page admin/build/themes/settings, if it is disabled.
the issue is related to http://drupal.org/node/19277
Keeping theme and block setting page consistent
Comment | File | Size | Author |
---|---|---|---|
#5 | admin-theme-settings_2.patch | 2.56 KB | Pasqualle |
#3 | admin-theme-settings_1.patch | 2.1 KB | Pasqualle |
admin-theme-settings.patch | 1.56 KB | Pasqualle | |
Comments
Comment #1
PasqualleComment #2
TapocoL CreditAttribution: TapocoL commentedOne suggestion I have is. To maintain consistency, you should also modify the 'list of themes' page to allow that page to configure the admin theme, as well. Go to 'admin/build/themes' to see the where the configure link needs to be.
Comment #3
Pasquallesorry, the previous link is wrong
the issue is related to http://drupal.org/node/192779 which is fixed now
added:
#2 configure link is displayed on page admin/build/themes for admin theme also
Comment #4
TapocoL CreditAttribution: TapocoL commentedThe patch has a problem. On the list of themes, if you set your administration theme to a bluemarine (for example), and then disable it, it will still remain checked on the page as enabled. However, it is getting saved in the database as disabled. So, the problem is the page is just displaying it as enabled when in fact it is DISabled. I have not been able to work with CVS/Patches well, but this is the fix for it:
Don't make any changes to the if in the system.admin.inc
Change the else attached to the if right after that to
I changed this code and the enabled check mark is gone because it does not make a new status array for it. And, the configure link works. I went through some of the configures and couldn't see any problems. I will test again on the next patch that can be made. Wish, I could just make the patches myself. :(
Comment #5
PasqualleYou are right, I missed the status change, thanks for the review.
Fixed the problem, not exactly the way you asked, but similar. I think the code is shorter this way.
Patch creation is really easy. If you are using windows, and have specific questions about it, don't hesitate to contact me..
And thanks for your help again, we need more reviewers. The issue queue is too long..
Comment #6
TapocoL CreditAttribution: TapocoL commentedI get the same results, as my statement. Could still navigate through theme config and save configs without problems. I think the patch is ready for commitment. However, change it back to review if you need more than just one reviewer.
Comment #7
Gábor HojtsyI fixed code style problems, and committed this, thanks.
Comment #8
(not verified) CreditAttribution: commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #9
Gábor HojtsyTurns out special casing the admin theme was not a good idea at all: #542828: Do not special case disabled admin theme