Hi,

After upgrading to 7.x-2.2, the following error message appears:

The following updates returned messages
service_links module
Update #6200 Failed: PDOException : SQLSTATE[42S22]: Column not found: 1054 Unknown column 'service_links_show_' in 'where clause': SELECT name FROM {variable} v WHERE LOCATE("service_links_show_",v.name) > 0; Array ( ) dans service_links_update_6200() (ligne 46 dans /home/bailleux/www/premium-car.lu/sites/all/modules/service_links/service_links.install).

Besides that, I am beeing asked to run database update script while it has been run twice.

Regards,
Gilles

Comments

StatusFileSize
new548 bytes

try this

Tried with the patch: the error is now:

Update #7201

Failed: PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'name' cannot be null: INSERT INTO {variable} (name, value) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1); Array ( [:db_insert_placeholder_0] => [:db_insert_placeholder_1] => a:0:{} ) in variable_set() (line 971 of /usr/share/drupal7/includes/bootstrap.inc).

@TheCrow: do you need info about the config?

StatusFileSize
new1.82 KB

This patch also fixes the 7201 update.

Thanks for the patch @monnerat. It took care of the update problem for me. One warning displayed when applying the patch though:

../drupal7-service_links-2.2-update.patch:16: trailing whitespace.
warning: 1 line adds whitespace errors.

Same here

The following updates returned messages
service_links module
Update #6200

Failed: PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'service_links_show_' in 'where clause': SELECT name FROM {variable} v WHERE LOCATE("service_links_show_",v.name) > 0; Array ( ) in service_links_update_6200() (regel 46 van /var/www/vhosts/XXXX/httpdocs/sites/all/modules/service_links/service_links.install).

#4 works!

Status:Active» Reviewed & tested by the community

#4 fixes update 7201 for me as well.

StatusFileSize
new1.82 KB

Same patch as #4, but without the trailing whitespaces at line 16.

#9 works for me on all my sites :-)

#9 works for me too.

no solution

new error

Update #7201
Failed: PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'name' cannot be null: INSERT INTO {variable} (name, value) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1); Array ( [:db_insert_placeholder_0] => [:db_insert_placeholder_1] => a:0:{} ) in variable_set() (regel 971 van /var/www/vhosts/XXXXXXX/httpdocs/includes/bootstrap.inc).

@Martin_S: You probably applied patch in comment #1. If so, try with patch in comment #9: it also fixes update 7201.

@monnerat

i used the Dev version

EDIT: after a manual #9 its fixed. Thanks

#9 works for me on all my sites , THX

Applying #9 and then re-performing the update.php (drush up) worked here.

#9 works fine

#9 works for me too.

This patch (indicated in #9) worked for me, as well.

Version:7.x-2.2» 7.x-2.x-dev
Status:Reviewed & tested by the community» Fixed

pushed!

when trying to run the patch in #9 I am getting the following.

serviidb:/var/www/serviidb.com/html/sites/all/modules/service_links# patch -p0 --dry-run < drupal7-service_links-2.2-update_1.patch
can't find file to patch at input line 4
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -Naurp service_links.orig/service_links.install service_links.new/service_links.install
|--- service_links.orig/service_links.install   2013-06-07 12:17:14.000000000 +0200
|+++ service_links.new/service_links.install    2013-06-10 15:26:43.256971524 +0200
--------------------------
File to patch:

Anyone have any idea what I am doing wrong?

I did
me@localhost:/var/www/drupal/sites/all/modules/service_links$ patch service_links.install drupal7-service_links-2.2-update_1.patch

and then a drush updatedb and it worked out fine.

To be clear, the command was:
patch service_links.install drupal7-service_links-2.2-update_1.patch
from within the service_links folder

Although, it looks like installing the dev version would fix this at this point as well.

Thanks that worked. Not sure why one way worked and other did not.

The June 14 Dev fixed the problem for me. 7.x-2.x-dev
thanks

The same problem for me, it was solved installing dev version, I write the steps because I'm not sure I did it right, and if so, it can help another half-ingnorant users like me:

- Without knowing this issue, I updated the module from 7.x-2.1 to 7.x-2.2
- then I updated the database in .../update.php and after this process it showed the ERROR
- I searched and found this thread, understood from #20 and the previous comments, that the correct tested patch is applied to 7.x-2.x-dev (the comment #20 is not very explicative to me),
- updated from 7.x-2.2 to 7.x-2.x-dev (date 2013-Jun-18) and updated database and there were no errors then. Everything is ok.

Thanks!

Status:Fixed» Reviewed & tested by the community

Thanks for the patch/dev.
Time to push the dev to a 2.3 version?!
When done: change this issue to fixed, I think :-).

Status:Reviewed & tested by the community» Fixed

The patch is in dev so nothing to fix

Probably i will release a beta because i want to add some other feature.

Status:Fixed» Needs work

Update #6200
Failed: PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'service_links_show_' in 'where clause': SELECT name FROM {variable} v WHERE LOCATE("service_links_show_",v.name) > 0; Array ( ) in service_links_update_6200() (line 46 of

upgraded from 2.2 to dev and it still fails.

Status:Needs work» Fixed

???
The failing SQL statement does not exist anymore in D7 dev.
You probably have failed updating or old instructions remained in some code cache.

That was the problem. I had two copies of service_links, one in sites/all/modules and one in sites/all/modules/contrib and I did not blow away one of them and that was what was being used. This is a defect in the way some packages (in this case Commerce) are constructed, that put contrib modules in their standard place, not my or Drupal's standard place. And a related issue is the standard Drupal update tab in modules which puts them in sites/all/modules and not where they currently are.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Confirmed that the latest dev does not have the problem. Would be great to have that pushed to a release version.

Updated to 2.3, but after running the update script, got a white screen with the URL:

http://crosstheriver.com/update.php?op=info

When I restore 2.2, I get the same white screen, unless I mark it as XXX_variable_OLD (how I mark previous versions of modules when updating), in which case I get this:

Warning: require_once(/home/cross936/public_html/sites/all/modules/XXX_variable_OLD/variable_realm/variable_realm.class.inc) [function.require-once]: failed to open stream: No such file or directory in _registry_check_code() (line 3097 of /home/cross936/public_html/includes/bootstrap.inc).

I press on, and everything seems normal, except that the variable is still marked as 'OLD', and I'm warned in 'Available Updates' that my Variable module is out of date.

After updating to Service Links latest dev version (7.x-2.3-beta1+1-dev) the update went through, and it seems to be working. Perhaps it's time to release it as the official version?

Priority:Normal» Major
Status:Closed (fixed)» Reviewed & tested by the community

I can also confirm that 7.x-2.3-beta1+1-dev and the 2.x-dev release both work without errors.

@TheCrow, I know you said you wanted to wait to do a new release that includes some other beta features, but it's important to get this bug squashed in the official release since it creates errors for anyone doing an upgrade. Ideally, Recommended Releases shouldn't contain known errors. And, it's been nearly two months since you marked this issue as fixed.

Thank you.

And for what it's worth, the 2.3+beta1 release is only visible for people who click the "View all releases" link at the bottom of the page. The least you could do is make it available as an "Other release".

This is the problem with Drupal -- you install some "great" modules, and they become unmaintained (or poorly maintained) over time. I'm not talking across major releases (that's beyond hope) but even in the same release.

Anyway, do you think it's a good idea do uninstall & reinstall the module?

Status:Reviewed & tested by the community» Closed (fixed)

Un-installing and re-installing the module shouldn't do any harm, in any case.

The code is fixed in the -dev version. The next release will probably happen after some other bugs have been fixed. For those who want it happen as soon as possible, please help by proposing patches or reviewing existing patches on open bug reports.

Thanks :)

#9 worked for me.

@moltra Just wanted to follow up and say the reason your application of the patch in #9 didn't work was because of the flag that you used, -p0. For applying patches created with git you need to use -p1 instead :) it's the small things sometimes!

Thanks all for the work on this patch (running #9 against 7.x-2.2). I would love to see a stable release that updates correctly soon :)

#9 Worked like a charm.
Commands used (while in service links directory):

wget "http://drupal.org/files/drupal7-service_links-2.2-update_1.patch"
patch -p1 <drupal7-service_links-2.2-update_1.patch

#9 worked for me as well.

Thanks vas01 for tip. On OS X first line would be:
curl -O http://drupal.org/files/drupal7-service_links-2.2-update_1.patch

#9 worked for me as well.

Issue summary:View changes

#9 worked for me

#9 working very well. Tks.