Why should the user still select a bundle? [#2016561]

Hello, I'm trying to use this module and at the moment I don't see any UI difference between this and the normal Commerce Feeds Importer.

Why do the Commerce Product multitype processor Settings still require the user to select a bundle? Shouldn't the user be able to select multiple bundles?

Thank you

Comment	File	Size	Author
#4	commerce_feedsmulti-update_to_generic_bundles-2016561-4-D7.patch	13.02 KB	AndyF

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

chebit CreditAttribution: chebit commented 15 June 2013 at 01:27

master, no work, crash ...

Fatal error: Call to undefined method FeedsMissingPlugin::getMappings() in /domain/sites/all/modules/feeds/feeds_ui/feeds_ui.admin.inc on line 491

lost data mapping, fuck!

thanks for your attempt!

Comment #2

zmove CreditAttribution: zmove commented 8 January 2014 at 14:33

+1. I don't see any difference with the commerce feeds module. The bundle field is still mandatory whereas that's the purpose of the module to not select bundle in settings but define it in the imported file instead.

So I don't understand how that module works.

Comment #3

OnkelTem CreditAttribution: OnkelTem commented 28 January 2015 at 12:23

Issue summary:

View changes

Same confusion — the module IS dedicated to dynamic product types, but on the configuration form we should select product type twice.

Another issue — it is supposed that the source contains product types? Isn't that too optimistic assumption? This suggests some preprocerssing of you the source to get data in sync with internal product types, but this is not the case when importing random data.

I think whole issue can be resolved with Rules. Now working on this.

Comment #4

AndyF CreditAttribution: AndyF commented 17 December 2015 at 13:43

Status:

Active

» Postponed

File	Size
commerce_feedsmulti-update_to_generic_bundles-2016561-4-D7.patch	13.02 KB

Hi,

There should be one select element that allows you to select the default product type. However there was a change in Feeds that caused Commerce Feeds and this module to show two different select elements (see #2635548: Update to use Feeds' new generic bundle handling). I've attached a patch that should resolve it for Commerce Feeds multitype - you'll also need the patch from the linked issue.

TODO: Commit patch once #2635548: Update to use Feeds' new generic bundle handling is fixed.
TODO: Add Commerce Feeds version dependency once #2635548: Update to use Feeds' new generic bundle handling is in a release.

Comment #5

AndyF CreditAttribution: AndyF commented 8 January 2016 at 16:36

I'm continuing development in branch generic_bundle_update_blocked_on_2635548 until the patch lands in Commerce Feeds.

Comment #6

26 July 2019 at 18:06

AndyF committed 8b1cc7d on 7.x-1.x

Issue #2016561 by AndyF: use Feeds new bundle handling

See https://www....

AndyF committed 5c0ad52 on 7.x-1.x

Issue #2016561 by AndyF: Require Feeds 2.0-alpha8+

It now requires...

Comment #7

AndyF CreditAttribution: AndyF commented 26 July 2019 at 18:40

Category:	Feature request	» Bug report
Status:	Postponed	» Fixed

I think we've waited long enough (: I've merged the changes into 7.x-1.x and added a hard requirement on Feeds 2.0-alpha8 or above and the Commerce Feeds patch.

Thanks all!