part of #2011290: [meta] standards cleanup to get ready for getting into core
Clean up the following file:
http://drupalcode.org/project/config_translation.git/blob/HEAD:/config_t...

Proposed resolution

Remaining tasks

User interface changes

No

API changes

No

Files: 
CommentFileSizeAuthor
#8 config_translation.module.2017887.8.patch560 bytesrobertdbailey
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch config_translation.module.2017887.8.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

Title:config_translation.module standards cleanup to get ready for getting into coreconfig_translation.services.yml standards cleanup to get ready for getting into core

Status:Needs work» Active

Status:Active» Needs work

#1938580: [META] Make active config save format match the default yml file (order and quotes) might be of use while looking at this one.

[edit: no, this isn't config or schema...]

Need to find another example of services.yml in core.

Status:Needs work» Active

Issue summary:View changes

updated UI/API changes sections to include "no"

Priority:Normal» Minor

In views:
http://drupalcode.org/project/drupal.git/blob/HEAD:/core/modules/views/v...

   views.route_access_check:
     class: Drupal\views\ViewsAccessCheck
     tags:
       - { name: 'access_check' }

the name is in single quotes and there is a space before the }

in core:
http://drupalcode.org/project/drupal.git/blob/HEAD:/core/core.services.y...

   access_check.default:
     class: Drupal\Core\Access\DefaultAccessCheck
     tags:
       - { name: access_check }

We have:

services:
  config_translation.subscriber:
    class: Drupal\config_translation\Routing\RouteSubscriber
    tags:
      - { name: event_subscriber}
  config_translation.access_check:
    class: Drupal\config_translation\Access\ConfigNameCheck
    tags:
      - { name: access_check}

So, I dont see anything blocking here.
I'm not even sure if there is anything to change.
Are these services.yml files hand written, or saved?

https://drupal.org/node/1937056
might be a change notice that says how to write it.

Oh, I should use blame and see which issue added this file.
#1985880: Convert to routing system
which references the WSCII conversion guide: https://drupal.org/node/1953342

I guess someone could add a space before the end }'s

Aside from that. It's fine as far as I can tell.

Status:Active» Needs review
StatusFileSize
new560 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch config_translation.module.2017887.8.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Status:Needs review» Reviewed & tested by the community

this look just fine! :) Thanks.

Status:Reviewed & tested by the community» Fixed

Superb, thanks, committed.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

added file link to description