This new feature is a huge improvement to many of the admin pages. Thanks + congrats to all who have contributed to this so far.

Can I suggest a couple of enhancements to make it even better:

1. While dragging an item, it's not that easy to see which one you have hold of - the very pale yellow doesn't show up well on my LCD at normal viewing angles. For disabled menu items, with the additional 50% opacity it's even worse. Patch for Garland's style.css and system.css attached, which makes the yellows stronger. I find this much easier to use as I can see what I am dragging much more easily. See attached screenshots also.

2. It would be great if you could somehow cancel a drag operation? ESC or dragging outside the window would be useful ways of doing this ... my JS skills aren't up to proposing a patch though!

Grateful for any comments etc.

[Screenshot naming convention: *-drag.jpg show the colours while the row is being dragged; *-drag-previous.jpg show the colours when the row is dropped. Note also the yellow is now stronger during the drag operation than after it is dropped. This makes sense to me...]

[Reposted from some of http://drupal.org/node/181066#comment-638589.]

Files: 
CommentFileSizeAuthor
#12 tabledrag_yellow_201876_12.patch245 bytesgpk
PASSED: [[SimpleTest]]: [MySQL] 190 pass(es).
[ View ]
#2 tabledrag_yellow_201876_a.patch241 bytesgpk
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch tabledrag_yellow_201876_a.patch.
[ View ]
new-drag-previous.jpg17.02 KBgpk
new-drag.jpg17.07 KBgpk
original-drag-previous.jpg17.66 KBgpk
original-drag.jpg17.6 KBgpk
tabledrag_yellow.patch722 bytesgpk
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in tabledrag_yellow.patch.
[ View ]

Comments

Just keeping on radar. I think the patch makes sense for system.css (where things are generally pretty ugly anyway), but not so much for Garland. Stefan Nagtegaal (the Garland designer) and I talked it over a few times about the colors used in Garland, but the default color used by other themes was never much debated.

Title:Drag and drop usability enhancementsDrag and drop usability enhancement - drag color
Component:javascript» Garland theme
Category:feature» bug
Status:Active» Needs review
StatusFileSize
new241 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch tabledrag_yellow_201876_a.patch.
[ View ]

OK this is a really tiny patch now.

All it does it make the yellow color slightly stronger while dragging an item in Garland (and Minelli) themes. This makes it much easier to see what you are doing.

Having a paler color while dragging makes sense for the other (older) core themes since these have a grey background for table rows. However, it looks like the same 'drag' color was copied into Garland's style.css without modification. Since the row background color in Garland is white for 'even' rows, the 'drag' color doesn't contrast at all with these.

Too see what the patch does, look at http://drupal.org/files/issues/new-drag-previous.jpg. With the current patch, this is the color *while dragging*.

Some other minor points:

1. Restricting this issue to be just about the "color while dragging" issue.
2. The 'drag-previous' color matches the 'div.warning' color. This clearly makes a lot of sense, so have discarded the proposed change there.

Title:Drag and drop usability enhancement - drag colorGarland: gpk doesn't like "Drag&drop"-drag color
Version:6.x-dev» 7.x-dev
Assigned:Unassigned» Stefan Nagtegaal
Status:Needs review» Patch (to be ported)

I'll look into this soon, but I fail to see why this has got to do anything related to usability..

Stefan

Thanks ;-)

>why this has got to do anything related to usability..
It just makes it a bit easier to see what you are doing IMO, especially when dragging a menu and its sub-items above or below another menu and its sub-items. And I'd say it makes more sense (in Garland at least) for the color to be slightly stronger while you are dragging.

Title:Garland: gpk doesn't like "Drag&drop"-drag colorGarland usability: Make "Drag & drop"-drag color stand out a little more
Status:Patch (to be ported)» Reviewed & tested by the community

Okay, after some thinking and searching looking around the web it seems you are right.
It does indeed make things a little better when we do have it stand out a little more..

This small patch in #2 is RTBC.

Status:Reviewed & tested by the community» Fixed

Committed to CVS HEAD.

Thanks guys for taking the trouble to look into this one :-)

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

Version:7.x-dev» 6.x-dev
Status:Closed (fixed)» Needs review

I was wondering why I was having trouble seeing the yellow on the row I was dragging in 6.x admin screens (with Garland as the admin theme) - but #2 was only applied to 7.x.

Tempted to set this to RTBC..

Is this still an issue using current Drupal 6?

Status:Needs review» Needs work

The last submitted patch, tabledrag_yellow_201876_a.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new245 bytes
PASSED: [[SimpleTest]]: [MySQL] 190 pass(es).
[ View ]

Yes, still an issue.

Have hacked the original patch to work with -p1, hope I got it right! Applies with offset -1.

Status:Needs review» Reviewed & tested by the community

Setting to RTBC per #5 and green light from testbot. Has already been applied to 7.x.

Excellent! Thanks.

Status:Reviewed & tested by the community» Fixed

Thanks, committed to Drupal 6.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.