This is a sub-issue of #1910606: Improve the configurations schemas for Views significantly.
Problem/motivation
#1866610: Introduce Kwalify-inspired schema format for configuration introduced some config schema coverage for views and #1910606: Improve the configurations schemas for Views significantly extended it, but it is not complete. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.
Proposed solution
Figure out the missing pieces that are not yet covered. Write schema file sections for them. Clean up / fix any issues in current schema.
Create a configuration schema for missing view relationship.
Schema in place
Please refer core/modules/views/config/schema/views.relationship.schema.yml
Standard.php
Schema not yet in place
Broken.php
GroupwiseMax.php
Comment | File | Size | Author |
---|---|---|---|
#4 | 2019087-4-add-missing-schema-for-views-relationship.patch | 1012 bytes | dropfen |
Comments
Comment #1
gobilo CreditAttribution: gobilo commentedComment #2
dropfen CreditAttribution: dropfen commentedComment #3
dropfen CreditAttribution: dropfen commentedWe (dropfen & gobilo) are working on this, as we understand it right, we just need to add the following to the views.relationship.schema.yml file:
Can we get short feedback, so we can create the patch?
Comment #4
dropfen CreditAttribution: dropfen commentedHere's the patch.
From dropfen & gobilo
Comment #5
dropfen CreditAttribution: dropfen commentedChange status.
Comment #6
dawehnerDo you know whether these options has to be in the same order as the actual form?
Comment #7
vijaycs85@dawehner, it would be nice, if we can have same order, but IMHO, config changes the order of fields on update. It should be fine, until the keys are in the proper intention. It looks good to me.
Comment #8
webchickCommitted and pushed to 8.x. Thanks!